[GitHub] [beam] aromanenko-dev commented on a diff in pull request #22485: Bugfix: Fix broken assertion in PipelineTest

[GitBox <gi...@apache.org>]

aromanenko-dev commented on code in PR #22485:
URL: https://github.com/apache/beam/pull/22485#discussion_r935638723


##########
sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java:
##########
@@ -407,13 +406,9 @@ public void testReplaceAll() {
         new PipelineVisitor.Defaults() {
           @Override
           public CompositeBehavior enterCompositeTransform(Node node) {
-            if (!node.isRootNode()) {
-              assertThat(
-                  node.getTransform().getClass(),
-                  not(
-                      anyOf(
-                          Matchers.equalTo(GenerateSequence.class),
-                          Matchers.equalTo(Create.Values.class))));
+            String fullName = node.getFullName();
+            if (fullName.equals("unbounded") || fullName.equals("bounded")) {
+              assertThat(node.getTransform(), Matchers.instanceOf(EmptyFlatten.class));

Review Comment:
   Could you explain this fix a bit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org