[GitHub] [kafka] fxbing commented on a diff in pull request #12333: MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"`

[GitBox <gi...@apache.org>]

fxbing commented on code in PR #12333:
URL: https://github.com/apache/kafka/pull/12333#discussion_r904456689


##########
core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala:
##########
@@ -341,12 +341,13 @@ class LogCleanerManagerTest extends Logging {
     */
   @Test
   def testLogsUnderCleanupIneligibleForCompaction(): Unit = {
-    val records = TestUtils.singletonRecords("test".getBytes, key="test".getBytes)
+    var records = TestUtils.singletonRecords("test".getBytes, key="test".getBytes)
     val log: UnifiedLog = createLog(records.sizeInBytes * 5, LogConfig.Delete)
     val cleanerManager: LogCleanerManager = createCleanerManager(log)
 
     log.appendAsLeader(records, leaderEpoch = 0)
     log.roll()
+    records = TestUtils.singletonRecords("test".getBytes, key="test".getBytes)

Review Comment:
   fixed, PTAL @divijvaidya 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org