You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/07 18:11:17 UTC

[GitHub] [nifi] mattyb149 commented on a change in pull request #5173: NIFI-8530: Improved DELETE handling in PutDatabaseRecord for non-nullable columns

mattyb149 commented on a change in pull request #5173:
URL: https://github.com/apache/nifi/pull/5173#discussion_r665601614



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -697,6 +697,7 @@ private void executeDML(final ProcessContext context, final ProcessSession sessi
                     final RecordSchema recordSchema = currentRecord.getSchema();
                     final Map<String, ColumnDescription> columns = tableSchema.getColumns();
 
+                    int deleteIndex = 0;

Review comment:
       Yeah that's the crux of the change, if the column is nullable you want to skip setting the second parameter, but using `i` will always advance the index whether the parameter was set or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org