You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/04 18:33:59 UTC

[GitHub] [hudi] pratyakshsharma commented on a change in pull request #2093: [HUDI-1200]: fixed NPE in CustomKeyGenerator

pratyakshsharma commented on a change in pull request #2093:
URL: https://github.com/apache/hudi/pull/2093#discussion_r499275214



##########
File path: hudi-spark/src/main/java/org/apache/hudi/keygen/CustomKeyGenerator.java
##########
@@ -58,6 +59,7 @@
 
   public CustomKeyGenerator(TypedProperties props) {
     super(props);
+    this.props = props;

Review comment:
       @bvaradar It has been like this from the very beginning. I am not sure of the reason though. Making config field non-transient is the easiest fix possible here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org