You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 13:23:42 UTC

[GitHub] [arrow] amol- commented on a diff in pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

amol- commented on code in PR #13311:
URL: https://github.com/apache/arrow/pull/13311#discussion_r894518980


##########
python/pyarrow/src_arrow/CMakeLists.txt:
##########
@@ -50,6 +79,14 @@ set(ARROW_PYTHON_SRCS
 set_source_files_properties(init.cc PROPERTIES SKIP_PRECOMPILE_HEADERS ON
                                                SKIP_UNITY_BUILD_INCLUSION ON)
 
+# Set necessary components on (from arrow/cpp/CMakeLists.txt, end of the file)
+set(ARROW_COMPUTE ON)
+set(ARROW_CSV ON)
+set(ARROW_DATASET ON)
+set(ARROW_FILESYSTEM ON)
+set(ARROW_HDFS ON)
+set(ARROW_JSON ON)

Review Comment:
   is this temporary? We shouldn't be forcefully enabling those as they are optional and PyArrow can be build without things like DATASETS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org