You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2024/01/17 07:57:43 UTC

[PR] [Fix](compile) fix compile failure on newest clang [doris]

zclllyybb opened a new pull request, #30056:
URL: https://github.com/apache/doris/pull/30056

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #30056:
URL: https://github.com/apache/doris/pull/30056


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895316990

   TeamCity be ut coverage result:
    Function Coverage: 36.66% (8648/23588) 
    Line Coverage: 28.72% (70604/245828)
    Region Coverage: 27.61% (36433/131939)
    Branch Coverage: 24.33% (18638/76594)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/46e78a01d4866b245b5fff18ec5671f611a3e5f1_46e78a01d4866b245b5fff18ec5671f611a3e5f1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895282981

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895341794

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 177326 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 46e78a01d4866b245b5fff18ec5671f611a3e5f1, data reload: false
   
   query1	929	337	332	332
   query2	6558	1919	1959	1919
   query3	6694	207	204	204
   query4	30934	22657	22568	22568
   query5	7988	533	540	533
   query6	962	182	179	179
   query7	6808	268	261	261
   query8	223	172	182	172
   query9	9534	2582	2543	2543
   query10	424	235	223	223
   query11	17164	15481	15341	15341
   query12	124	69	68	68
   query13	1688	372	380	372
   query14	10349	6916	6900	6900
   query15	203	175	183	175
   query16	4595	232	226	226
   query17	1000	478	483	478
   query18	1771	263	249	249
   query19	179	145	132	132
   query20	70	67	64	64
   query21	186	128	133	128
   query22	5202	5054	4956	4956
   query23	31703	30796	30624	30624
   query24	11453	2823	2801	2801
   query25	555	310	314	310
   query26	915	139	142	139
   query27	2893	266	269	266
   query28	6503	1836	1825	1825
   query29	993	619	626	619
   query30	276	134	138	134
   query31	939	750	751	750
   query32	87	52	48	48
   query33	692	218	204	204
   query34	1134	457	464	457
   query35	905	794	816	794
   query36	1411	1274	1209	1209
   query37	86	56	57	56
   query38	3388	3273	3233	3233
   query39	1301	1260	1266	1260
   query40	201	86	79	79
   query41	36	35	34	34
   query42	93	82	86	82
   query43	513	481	508	481
   query44	1072	684	688	684
   query45	197	176	174	174
   query46	1048	651	647	647
   query47	1645	1597	1548	1548
   query48	410	315	327	315
   query49	1126	285	296	285
   query50	669	313	300	300
   query51	5303	5267	5211	5211
   query52	87	81	83	81
   query53	330	251	257	251
   query54	880	428	436	428
   query55	81	77	72	72
   query56	175	165	162	162
   query57	965	924	897	897
   query58	189	164	159	159
   query59	2914	2718	2747	2718
   query60	211	182	188	182
   query61	88	84	81	81
   query62	639	389	389	389
   query63	286	256	247	247
   query64	4636	1829	1753	1753
   query65	3332	3253	3249	3249
   query66	1237	334	318	318
   query67	15515	15510	15096	15096
   query68	11200	504	509	504
   query69	618	300	310	300
   query70	1689	1520	1468	1468
   query71	559	206	206	206
   query72	5104	2841	2851	2841
   query73	2093	323	313	313
   query74	7026	6343	6422	6343
   query75	4902	2289	2272	2272
   query76	6194	1032	1021	1021
   query77	669	238	245	238
   query78	9081	8812	8601	8601
   query79	1012	490	493	490
   query80	579	303	304	303
   query81	462	205	201	201
   query82	201	77	82	77
   query83	143	119	122	119
   query84	275	66	70	66
   query85	1044	333	321	321
   query86	379	421	376	376
   query87	3501	3413	3317	3317
   query88	2969	2277	2265	2265
   query89	422	356	358	356
   query90	1991	191	185	185
   query91	155	135	124	124
   query92	52	45	43	43
   query93	2461	401	398	398
   query94	1227	154	158	154
   query95	491	444	438	438
   query96	629	322	333	322
   query97	4292	4129	4166	4129
   query98	203	198	194	194
   query99	1003	713	666	666
   Total cold run time: 295323 ms
   Total hot run time: 177326 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895324122

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38536 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 46e78a01d4866b245b5fff18ec5671f611a3e5f1, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17639	5204	5210	5204
   q2	2048	142	129	129
   q3	10754	1119	1147	1119
   q4	10325	756	760	756
   q5	7765	3191	3107	3107
   q6	213	121	119	119
   q7	875	499	474	474
   q8	9264	1929	1944	1929
   q9	7196	6378	6331	6331
   q10	8234	3055	3031	3031
   q11	415	207	203	203
   q12	354	191	195	191
   q13	17996	3356	3331	3331
   q14	249	221	219	219
   q15	544	502	495	495
   q16	452	372	387	372
   q17	927	552	504	504
   q18	7560	6879	6712	6712
   q19	1768	1315	1459	1315
   q20	589	312	290	290
   q21	2763	2413	2417	2413
   q22	369	297	292	292
   Total cold run time: 108299 ms
   Total hot run time: 38536 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5441	5343	5296	5296
   q2	322	214	212	212
   q3	3323	3216	3201	3201
   q4	2112	2043	2068	2043
   q5	6012	5820	5908	5820
   q6	195	117	117	117
   q7	2283	1875	1862	1862
   q8	3228	3355	3404	3355
   q9	8925	8926	8715	8715
   q10	3829	3858	3809	3809
   q11	572	463	444	444
   q12	790	614	622	614
   q13	16888	3138	3116	3116
   q14	281	259	264	259
   q15	562	505	509	505
   q16	525	466	476	466
   q17	1865	1886	1828	1828
   q18	9394	19514	9567	9567
   q19	24834	1614	1530	1530
   q20	4672	1949	1916	1916
   q21	14453	5484	5467	5467
   q22	999	496	546	496
   Total cold run time: 111505 ms
   Total hot run time: 60638 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895283041

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895350530

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.81 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 46e78a01d4866b245b5fff18ec5671f611a3e5f1, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.02	0.02
   query3	0.23	0.04	0.04
   query4	1.69	0.06	0.07
   query5	0.53	0.52	0.53
   query6	1.34	0.64	0.63
   query7	0.02	0.02	0.01
   query8	0.04	0.03	0.02
   query9	0.55	0.51	0.50
   query10	0.56	0.54	0.56
   query11	0.12	0.09	0.09
   query12	0.11	0.08	0.08
   query13	0.61	0.68	0.60
   query14	0.77	0.77	0.78
   query15	0.79	0.77	0.77
   query16	0.39	0.39	0.39
   query17	1.03	1.01	0.99
   query18	0.23	0.25	0.23
   query19	1.89	1.73	1.79
   query20	0.01	0.01	0.01
   query21	15.39	0.59	0.56
   query22	2.46	2.51	2.16
   query23	17.31	0.88	0.80
   query24	2.55	1.05	0.82
   query25	0.48	0.21	0.19
   query26	0.45	0.12	0.13
   query27	0.06	0.05	0.04
   query28	11.96	0.74	0.76
   query29	12.58	3.19	3.09
   query30	0.54	0.48	0.45
   query31	2.78	0.33	0.35
   query32	3.36	0.48	0.48
   query33	3.22	3.22	3.21
   query34	16.01	4.25	4.31
   query35	4.28	4.22	4.28
   query36	1.11	1.08	1.08
   query37	0.06	0.05	0.05
   query38	0.04	0.02	0.03
   query39	0.03	0.01	0.02
   query40	0.16	0.12	0.14
   query41	0.06	0.01	0.02
   query42	0.02	0.01	0.01
   query43	0.03	0.02	0.02
   Total cold run time: 105.94 s
   Total hot run time: 30.81 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895289635

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895355638

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 46e78a01d4866b245b5fff18ec5671f611a3e5f1 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       14.9 seconds inserted 10000000 Rows, about 671K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](compile) fix compile failure on newest clang [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #30056:
URL: https://github.com/apache/doris/pull/30056#issuecomment-1895279506

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org