You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/04/27 20:21:12 UTC

[GitHub] [myfaces] volosied commented on a diff in pull request #255: MYFACES-4433 - Fix ViewScopeContextualStorage memory leak

volosied commented on code in PR #255:
URL: https://github.com/apache/myfaces/pull/255#discussion_r860212512


##########
impl/src/main/java/org/apache/myfaces/cdi/view/ViewScopeBeanHolder.java:
##########
@@ -236,4 +236,8 @@ public String generateUniqueViewScopeId()
         return key;
     }
 
+    public void removeStorage(String viewScopeId){

Review Comment:
   Maybe rename this to `removeStorageContextFromMap` instead?  
   
   Let me know if you have a preference or any other suggestions. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org