[GH] (poi/fix-xssf-resolve-book-index): Workflow run "Java CI with Ant" is working again!

[GitBox <gi...@apache.org>]

The GitHub Actions job "Java CI with Ant" on poi.git/fix-xssf-resolve-book-index has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
260bb092bdbeadd6c72f11f326b07e5c3bd714e0 / PJ Fanning <pj...@users.noreply.github.com>
Fix off-by-one when stripping the [] wrapper from an external book name

BaseXSSFEvaluationWorkbook.resolveBookIndex used substring(1, length()-2)
to strip the [] wrapper from a book name, which also dropped the last
character of the name itself - "[Book1.xlsx]" became "Book1.xls". The
external links lookup then missed and, unless the name happened to look
like a 'file:///...' reference, the call failed with "Book not linked for
filename ...".

While in the same method:

* don't depend on FormulaParser leaving the single quotes around a quoted
  book name in place - accept an absolute file reference with or without
  them;
* guard findExternalLinkIndex against a null table list, which
  XSSFWorkbook.getExternalLinksTables() can return, and re-fetch the list
  after adding a placeholder rather than assuming the one we looked up is
  live.

Co-Authored-By: Claude Opus 5 (1M context) <no...@anthropic.com>

Report URL: https://github.com/apache/poi/actions/runs/33814080798

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org