You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2021/01/05 01:09:29 UTC
Review Request 73114: RANGER-3140:Ranger ShutdownHook hook to be
called in
RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73114/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3140
https://issues.apache.org/jira/browse/RANGER-3140
Repository: ranger
Description
-------
RANGER-3140:Ranger ShutdownHook hook to be called in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 1be9c2f86
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java cbd819dda
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java 1b13d3b8f
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d9872ff6c
Diff: https://reviews.apache.org/r/73114/diff/1/
Testing
-------
- Verified in a local vm for HBase shutdown
Thanks,
Ramesh Mani
Re: Review Request 73114: RANGER-3140:Ranger ShutdownHook hook to be
called
in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73114/#review222402
-----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java
Lines 481 (patched)
<https://reviews.apache.org/r/73114/#comment311449>
Consider using this.componentAppType, instead of MiscUtil.getApplicationType().
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
Lines 1837 (patched)
<https://reviews.apache.org/r/73114/#comment311448>
Exception thrown is caught in following catch block, and ignored. Perhaps try/catch block can be replaced with the warn message at #1839?
- Madhan Neethiraj
On Jan. 5, 2021, 1:09 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73114/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2021, 1:09 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3140
> https://issues.apache.org/jira/browse/RANGER-3140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3140:Ranger ShutdownHook hook to be called in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 1be9c2f86
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java cbd819dda
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java 1b13d3b8f
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d9872ff6c
>
>
> Diff: https://reviews.apache.org/r/73114/diff/1/
>
>
> Testing
> -------
>
> - Verified in a local vm for HBase shutdown
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73114: RANGER-3140:Ranger ShutdownHook hook to be
called
in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73114/#review222405
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 5, 2021, 7:38 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73114/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2021, 7:38 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3140
> https://issues.apache.org/jira/browse/RANGER-3140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3140:Ranger ShutdownHook hook to be called in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 1be9c2f86
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java cbd819dda
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java 1b13d3b8f
> hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d9872ff6c
>
>
> Diff: https://reviews.apache.org/r/73114/diff/2/
>
>
> Testing
> -------
>
> - Verified in a local vm for HBase shutdown
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73114: RANGER-3140:Ranger ShutdownHook hook to be
called
in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73114/
-----------------------------------------------------------
(Updated Jan. 5, 2021, 7:38 a.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Bugs: RANGER-3140
https://issues.apache.org/jira/browse/RANGER-3140
Repository: ranger
Description
-------
RANGER-3140:Ranger ShutdownHook hook to be called in RangerHBaseCoprocessor preShutdown apis for a clean shutdown of HBase
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 1be9c2f86
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java cbd819dda
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java 1b13d3b8f
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d9872ff6c
Diff: https://reviews.apache.org/r/73114/diff/2/
Changes: https://reviews.apache.org/r/73114/diff/1-2/
Testing
-------
- Verified in a local vm for HBase shutdown
Thanks,
Ramesh Mani