[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7621: add extra properties to the tuner,

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7621:
URL: https://github.com/apache/pinot/pull/7621#discussion_r734877659



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##########
@@ -32,13 +33,13 @@
 public interface TableConfigTuner {
 
   /**
-   * Used to initialize underlying implementation with Schema
-   * and custom properties (eg: metrics end point)
+   * Apply tuner to a {@link TableConfig}.
    *
    * @param pinotHelixResourceManager Pinot Helix Resource Manager to access Helix resources
    * @param tableConfig tableConfig that needs to be tuned.
    * @param schema Table schema
+   * @param extraProperties extraProperties for the tuner implementation.
    */
   TableConfig apply(@Nullable PinotHelixResourceManager pinotHelixResourceManager,
-      TableConfig tableConfig, Schema schema);
+      TableConfig tableConfig, Schema schema, Map<String, String> extraProperties);

Review comment:
       Rename it to `tunerProperties`? I can see the value of having it passed in explicitly to make the code more modularized, but it should be the same as the `TunerConfig._tunerProperties`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org