[GitHub] [superset] suddjian commented on a change in pull request #18652: feat: Introduce a library for embedded iframe <-> host communication

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #18652:
URL: https://github.com/apache/superset/pull/18652#discussion_r803212633



##########
File path: superset-embedded-sdk/package.json
##########
@@ -22,7 +22,7 @@
   "module": "lib/index.js",
   "types": "dist/index.d.ts",
   "scripts": {
-    "build": "tsc & babel src --out-dir lib --extensions '.ts,.tsx' & webpack --mode production",
+    "build": "tsc ; babel src --out-dir lib --extensions '.ts,.tsx' ; webpack --mode production",

Review comment:
       I didn't realize this before but `&` actually starts a process in the background instead of working like `Promise.all`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org