You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Yiqun Lin (JIRA)" <ji...@apache.org> on 2018/09/18 09:52:00 UTC

[jira] [Created] (HADOOP-15768) Do not use Time#now to calculate the rpc queue time duration

Yiqun Lin created HADOOP-15768:
----------------------------------

             Summary: Do not use Time#now to calculate the rpc queue time duration
                 Key: HADOOP-15768
                 URL: https://issues.apache.org/jira/browse/HADOOP-15768
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 3.1.1
            Reporter: Yiqun Lin
            Assignee: Ryan Wu


For the rpc queue time calculation, we are using a not-recommended way: Using {{Time#now}} to calculate for this.
{code}
        // Invoke the protocol method
        long startTime = Time.now();
        int qTime = (int) (startTime-receivedTime);
....
server.updateMetrics(detailedMetricsName, qTime, processingTime, false);
{code} 

We should use {{Time#monotonicNow()}} instead. This JIRA will fix these across RpcEngine impl classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org