You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/20 18:44:15 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1948: HDDS-4850. Intermittent failure in ozonesecure due to unable to allocate block
adoroszlai opened a new pull request #1948:
URL: https://github.com/apache/ozone/pull/1948
## What changes were proposed in this pull request?
HDDS-4834 added a new test case in `ozonesecure`, which apparently causes flakiness in later container-related test.
This PR moves the replication test, which requires datanode restart, to the end of the test suite.
https://issues.apache.org/jira/browse/HDDS-4850
## How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/584182478
acceptance (secure) 10x:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/584359630
https://github.com/adoroszlai/hadoop-ozone/actions/runs/584573002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #1948: HDDS-4850. Intermittent failure in ozonesecure due to unable to allocate block
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1948:
URL: https://github.com/apache/ozone/pull/1948#discussion_r580213768
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/replicationmanager.robot
##########
@@ -30,16 +30,16 @@ Check replicationmanager with explicit host
Should contain ${output} ReplicationManager
Should contain ${output} Running
-Start replicationmanager
- ${output} = Execute ozone admin replicationmanager start
- Should contain ${output} Starting ReplicationManager
- Wait Until Keyword Succeeds 30sec 5sec Execute ozone admin replicationmanager status | grep -q 'is Running'
-
Stop replicationmanager
${output} = Execute ozone admin replicationmanager stop
Should contain ${output} Stopping ReplicationManager
Wait Until Keyword Succeeds 30sec 5sec Execute ozone admin replicationmanager status | grep -q 'is Not Running'
+Start replicationmanager
Review comment:
Thanks @smengcl for the review.
> before this change, the replicationmanager was stopped when admincli robot test finish?
Yes.
> and this wasn't failing other tests after this?
I don't think any acceptance test triggered replication so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #1948: HDDS-4850. Intermittent failure in ozonesecure due to unable to allocate block
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #1948:
URL: https://github.com/apache/ozone/pull/1948#discussion_r580521697
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/replicationmanager.robot
##########
@@ -30,16 +30,16 @@ Check replicationmanager with explicit host
Should contain ${output} ReplicationManager
Should contain ${output} Running
-Start replicationmanager
- ${output} = Execute ozone admin replicationmanager start
- Should contain ${output} Starting ReplicationManager
- Wait Until Keyword Succeeds 30sec 5sec Execute ozone admin replicationmanager status | grep -q 'is Running'
-
Stop replicationmanager
${output} = Execute ozone admin replicationmanager stop
Should contain ${output} Stopping ReplicationManager
Wait Until Keyword Succeeds 30sec 5sec Execute ozone admin replicationmanager status | grep -q 'is Not Running'
+Start replicationmanager
Review comment:
Got it. Thanks @adoroszlai !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #1948: HDDS-4850. Intermittent failure in ozonesecure due to unable to allocate block
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #1948:
URL: https://github.com/apache/ozone/pull/1948#discussion_r580212221
##########
File path: hadoop-ozone/dist/src/main/smoketest/admincli/replicationmanager.robot
##########
@@ -30,16 +30,16 @@ Check replicationmanager with explicit host
Should contain ${output} ReplicationManager
Should contain ${output} Running
-Start replicationmanager
- ${output} = Execute ozone admin replicationmanager start
- Should contain ${output} Starting ReplicationManager
- Wait Until Keyword Succeeds 30sec 5sec Execute ozone admin replicationmanager status | grep -q 'is Running'
-
Stop replicationmanager
${output} = Execute ozone admin replicationmanager stop
Should contain ${output} Stopping ReplicationManager
Wait Until Keyword Succeeds 30sec 5sec Execute ozone admin replicationmanager status | grep -q 'is Not Running'
+Start replicationmanager
Review comment:
hmm i'm curious.. before this change, the replicationmanager was stopped when admincli robot test finish? and this wasn't failing other tests after this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #1948: HDDS-4850. Intermittent failure in ozonesecure due to unable to allocate block
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1948:
URL: https://github.com/apache/ozone/pull/1948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org