You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/14 09:54:39 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7419: [AIRFLOW-6804][depends on AIRFLOW-6792] Add the basic test for all example DAGs

nuclearpinguin commented on a change in pull request #7419:  [AIRFLOW-6804][depends on AIRFLOW-6792] Add the basic test for all example DAGs
URL: https://github.com/apache/airflow/pull/7419#discussion_r379340229
 
 

 ##########
 File path: tests/test_project_structure.py
 ##########
 @@ -251,3 +250,20 @@ def find_resource_files(department="*", resource_type="*", service="*"):
         # Exclude __init__.py and pycache
         resource_files = (f for f in resource_files if not f.endswith("__init__.py"))
         return resource_files
+
+
+class TestOperatorsHooks(unittest.TestCase):
+    def test_some_suffix_is_illegal(self):
 
 Review comment:
   ```suggestion
       def test_no_illegal_suffixes(self):
             illegal_suffixes = ["_operator.py", "_hook.py", "_sensor.py"]
   ```
   WDYT? Will it make the test easier to understand?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services