You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Marios Trivyzas (Jira)" <ji...@apache.org> on 2022/03/10 14:12:00 UTC

[jira] [Updated] (FLINK-26587) Replace Configuration arg of RichFunction#open with ReadableConfig

     [ https://issues.apache.org/jira/browse/FLINK-26587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marios Trivyzas updated FLINK-26587:
------------------------------------
    Description: 
It would be nice to replace the more concrete *Configuration* with *ReadableConfig* since according the the javadoc description of the method *RichFunction#open* the Configuration is a read-only object from which the function can retrieve and use config options.

 

Since *RichFunction* is an old public interface, maybe we can introduce the new *open(ReadableConfig parameters),* deprecate the old *open(Configuration parameters)* and make it call the new one:
{noformat}
default void open(Configuration parameters) throws Exception {
    open((ReadableConfig) parameters);
}

void open(ReadableConfig parameters) throws Exception;{noformat}

  was:It would be nice to replace the more concrete *Configuration* with *ReadableConfig* since according the the javadoc description of the method *RichFunction#open* the Configuration is a read-only object from which the function can retrieve and use config options.


> Replace Configuration arg of RichFunction#open with ReadableConfig
> ------------------------------------------------------------------
>
>                 Key: FLINK-26587
>                 URL: https://issues.apache.org/jira/browse/FLINK-26587
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Core
>            Reporter: Marios Trivyzas
>            Priority: Major
>
> It would be nice to replace the more concrete *Configuration* with *ReadableConfig* since according the the javadoc description of the method *RichFunction#open* the Configuration is a read-only object from which the function can retrieve and use config options.
>  
> Since *RichFunction* is an old public interface, maybe we can introduce the new *open(ReadableConfig parameters),* deprecate the old *open(Configuration parameters)* and make it call the new one:
> {noformat}
> default void open(Configuration parameters) throws Exception {
>     open((ReadableConfig) parameters);
> }
> void open(ReadableConfig parameters) throws Exception;{noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)