You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Peter Vary <pv...@cloudera.com> on 2017/05/16 13:12:49 UTC
Review Request 59310: HIVE-15051 Test framework integration with
findbugs, rat checks etc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59310/
-----------------------------------------------------------
Review request for hive, Akira Ajisaka, Marta Kuczora, Siddharth Seth, Thejas Nair, Vihang Karajgaonkar, and Barna Zsombor Klara.
Repository: hive-git
Description
-------
Integrated Apache Yetus (https://yetus.apache.org/)
- Created hive personality to contain the hive specific configurations
- Created yetus-wrapper.sh to download yetus and patch the not yet released changes:
-- checkstyle_YETUS-484.sh
-- findbugs_YETUS-471.sh
-- maven_YETUS-506.sh
- Created test-patch.sh, and smart-apply-patch.sh to simplify testing/applying patch
- Added patchprocess directory to gitignore
- Two small modification in pom.xml
-- Adding findbugs configuration to build
-- Disabling failure on javadoc errors
Diffs
-----
.gitignore 47c59da
dev-support/checkstyle_YETUS-484.sh PRE-CREATION
dev-support/findbugs_YETUS-471.sh PRE-CREATION
dev-support/hive-personality.sh PRE-CREATION
dev-support/maven_YETUS-506.sh PRE-CREATION
dev-support/smart-apply-patch.sh PRE-CREATION
dev-support/test-patch.sh PRE-CREATION
dev-support/yetus-wrapper.sh PRE-CREATION
pom.xml 30fa50b
Diff: https://reviews.apache.org/r/59310/diff/1/
Testing
-------
To test a patch set the FINDBUGS_HOME, and go to the hive source root directory and run the test_patch.sh command like this:
./[petervary:~/dev/upstream/hive] $ export FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh ~/Downloads/HIVE-16345.2.patch
Thanks,
Peter Vary
Re: Review Request 59310: HIVE-15051 Test framework integration with
findbugs, rat checks etc.
Posted by Peter Vary <pv...@cloudera.com>.
> On May 17, 2017, 8:09 p.m., Akira Ajisaka wrote:
> >
Thanks for the review Akira!
> On May 17, 2017, 8:09 p.m., Akira Ajisaka wrote:
> > dev-support/hive-personality.sh
> > Lines 29 (patched)
> > <https://reviews.apache.org/r/59310/diff/1/?file=1720883#file1720883line29>
> >
> > 'trunk' should be 'master' in Apache Hive.
Changed! Thanks for the catch!
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59310/#review175312
-----------------------------------------------------------
On May 18, 2017, 1:55 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59310/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 1:55 p.m.)
>
>
> Review request for hive, Akira Ajisaka, Marta Kuczora, Siddharth Seth, Thejas Nair, Vihang Karajgaonkar, and Barna Zsombor Klara.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Integrated Apache Yetus (https://yetus.apache.org/)
> - Created hive personality to contain the hive specific configurations
> - Created yetus-wrapper.sh to download yetus and patch the not yet released changes:
> -- checkstyle_YETUS-484.sh
> -- findbugs_YETUS-471.sh
> -- maven_YETUS-506.sh
> - Created test-patch.sh, and smart-apply-patch.sh to simplify testing/applying patch
> - Added patchprocess directory to gitignore
> - Two small modification in pom.xml
> -- Adding findbugs configuration to build
> -- Disabling failure on javadoc errors
>
>
> Diffs
> -----
>
> .gitignore 47c59da
> dev-support/checkstyle_YETUS-484.sh PRE-CREATION
> dev-support/findbugs_YETUS-471.sh PRE-CREATION
> dev-support/hive-personality.sh PRE-CREATION
> dev-support/maven_YETUS-506.sh PRE-CREATION
> dev-support/smart-apply-patch.sh PRE-CREATION
> dev-support/test-patch.sh PRE-CREATION
> dev-support/yetus-wrapper.sh PRE-CREATION
> pom.xml 30fa50b
>
>
> Diff: https://reviews.apache.org/r/59310/diff/2/
>
>
> Testing
> -------
>
> To test a patch set the FINDBUGS_HOME, and go to the hive source root directory and run the test_patch.sh command like this:
> ./[petervary:~/dev/upstream/hive] $ export FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
> ./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh ~/Downloads/HIVE-16345.2.patch
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 59310: HIVE-15051 Test framework integration with
findbugs, rat checks etc.
Posted by Akira Ajisaka <aa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59310/#review175312
-----------------------------------------------------------
dev-support/hive-personality.sh
Lines 29 (patched)
<https://reviews.apache.org/r/59310/#comment248768>
'trunk' should be 'master' in Apache Hive.
- Akira Ajisaka
On 5月 16, 2017, 1:12 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59310/
> -----------------------------------------------------------
>
> (Updated 5月 16, 2017, 1:12 p.m.)
>
>
> Review request for hive, Akira Ajisaka, Marta Kuczora, Siddharth Seth, Thejas Nair, Vihang Karajgaonkar, and Barna Zsombor Klara.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Integrated Apache Yetus (https://yetus.apache.org/)
> - Created hive personality to contain the hive specific configurations
> - Created yetus-wrapper.sh to download yetus and patch the not yet released changes:
> -- checkstyle_YETUS-484.sh
> -- findbugs_YETUS-471.sh
> -- maven_YETUS-506.sh
> - Created test-patch.sh, and smart-apply-patch.sh to simplify testing/applying patch
> - Added patchprocess directory to gitignore
> - Two small modification in pom.xml
> -- Adding findbugs configuration to build
> -- Disabling failure on javadoc errors
>
>
> Diffs
> -----
>
> .gitignore 47c59da
> dev-support/checkstyle_YETUS-484.sh PRE-CREATION
> dev-support/findbugs_YETUS-471.sh PRE-CREATION
> dev-support/hive-personality.sh PRE-CREATION
> dev-support/maven_YETUS-506.sh PRE-CREATION
> dev-support/smart-apply-patch.sh PRE-CREATION
> dev-support/test-patch.sh PRE-CREATION
> dev-support/yetus-wrapper.sh PRE-CREATION
> pom.xml 30fa50b
>
>
> Diff: https://reviews.apache.org/r/59310/diff/1/
>
>
> Testing
> -------
>
> To test a patch set the FINDBUGS_HOME, and go to the hive source root directory and run the test_patch.sh command like this:
> ./[petervary:~/dev/upstream/hive] $ export FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
> ./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh ~/Downloads/HIVE-16345.2.patch
>
>
> Thanks,
>
> Peter Vary
>
>
Re: Review Request 59310: HIVE-15051 Test framework integration with
findbugs, rat checks etc.
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59310/
-----------------------------------------------------------
(Updated May 30, 2017, 9:38 p.m.)
Review request for hive, Akira Ajisaka, Marta Kuczora, Siddharth Seth, Thejas Nair, Vihang Karajgaonkar, and Barna Zsombor Klara.
Changes
-------
Addressed review comments.
Running full build on clean branch before starting the tests.
Repository: hive-git
Description
-------
Integrated Apache Yetus (https://yetus.apache.org/)
- Created hive personality to contain the hive specific configurations
- Created yetus-wrapper.sh to download yetus and patch the not yet released changes:
-- checkstyle_YETUS-484.sh
-- findbugs_YETUS-471.sh
-- maven_YETUS-506.sh
- Created test-patch.sh, and smart-apply-patch.sh to simplify testing/applying patch
- Added patchprocess directory to gitignore
- Two small modification in pom.xml
-- Adding findbugs configuration to build
-- Disabling failure on javadoc errors
Diffs (updated)
-----
.gitignore 47c59da
dev-support/checkstyle_YETUS-484.sh PRE-CREATION
dev-support/findbugs_YETUS-471.sh PRE-CREATION
dev-support/hive-personality.sh PRE-CREATION
dev-support/maven_YETUS-506.sh PRE-CREATION
dev-support/smart-apply-patch.sh PRE-CREATION
dev-support/test-patch.sh PRE-CREATION
dev-support/yetus-wrapper.sh PRE-CREATION
pom.xml 30fa50b
Diff: https://reviews.apache.org/r/59310/diff/3/
Changes: https://reviews.apache.org/r/59310/diff/2-3/
Testing
-------
To test a patch set the FINDBUGS_HOME, and go to the hive source root directory and run the test_patch.sh command like this:
./[petervary:~/dev/upstream/hive] $ export FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh ~/Downloads/HIVE-16345.2.patch
Thanks,
Peter Vary
Re: Review Request 59310: HIVE-15051 Test framework integration with
findbugs, rat checks etc.
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59310/
-----------------------------------------------------------
(Updated May 18, 2017, 1:55 p.m.)
Review request for hive, Akira Ajisaka, Marta Kuczora, Siddharth Seth, Thejas Nair, Vihang Karajgaonkar, and Barna Zsombor Klara.
Changes
-------
updated the default branch to master - based on Akira Ajisaka's comment
updated the maven.sh with the review comments on yetus jira - there might come some more small changes there.
Repository: hive-git
Description
-------
Integrated Apache Yetus (https://yetus.apache.org/)
- Created hive personality to contain the hive specific configurations
- Created yetus-wrapper.sh to download yetus and patch the not yet released changes:
-- checkstyle_YETUS-484.sh
-- findbugs_YETUS-471.sh
-- maven_YETUS-506.sh
- Created test-patch.sh, and smart-apply-patch.sh to simplify testing/applying patch
- Added patchprocess directory to gitignore
- Two small modification in pom.xml
-- Adding findbugs configuration to build
-- Disabling failure on javadoc errors
Diffs (updated)
-----
.gitignore 47c59da
dev-support/checkstyle_YETUS-484.sh PRE-CREATION
dev-support/findbugs_YETUS-471.sh PRE-CREATION
dev-support/hive-personality.sh PRE-CREATION
dev-support/maven_YETUS-506.sh PRE-CREATION
dev-support/smart-apply-patch.sh PRE-CREATION
dev-support/test-patch.sh PRE-CREATION
dev-support/yetus-wrapper.sh PRE-CREATION
pom.xml 30fa50b
Diff: https://reviews.apache.org/r/59310/diff/2/
Changes: https://reviews.apache.org/r/59310/diff/1-2/
Testing
-------
To test a patch set the FINDBUGS_HOME, and go to the hive source root directory and run the test_patch.sh command like this:
./[petervary:~/dev/upstream/hive] $ export FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh ~/Downloads/HIVE-16345.2.patch
Thanks,
Peter Vary