[GitHub] [ozone] yuangu002 commented on a change in pull request #2565: HDDS-5368. Add CLI command: ozone admin namespace summary

[GitBox <gi...@apache.org>]

yuangu002 commented on a change in pull request #2565:
URL: https://github.com/apache/ozone/pull/2565#discussion_r694991611



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java
##########
@@ -314,6 +316,48 @@ public static InetSocketAddress getReconAddresses(
     return NetUtils.createSocketAddr(hostname.get(), port);
   }
 
+  /**
+   * Retrieve the socket addresses of recon HTTP.
+   *
+   * @return Recon address
+   * @throws IllegalArgumentException If the configuration is invalid
+   */
+  public static InetSocketAddress getReconHTTPAddresses(
+      ConfigurationSource conf) {
+    String name = conf.get(OZONE_RECON_HTTP_ADDRESS_KEY);

Review comment:
       `OZONE_RECON_ADDRESS_KEY` maps to `recon:9891`, which is the address for RPC client. In our case, I think we still need `OZONE_RECON_HTTP_ADDRESS_KEY` and `OZONE_RECON_HTTPS_ADDRESS_KEY` which maps to web endpoints.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org