You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2023/08/29 09:23:22 UTC
[GitHub] [camel] oscerd opened a new pull request, #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
oscerd opened a new pull request, #11228:
URL: https://github.com/apache/camel/pull/11228
…vailable
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1699617663
Be very careful though cause these conventions are NOT stable. That means that they can do a breaking change and if we say that Camel is opentelemetry semantic convention compatible, you would be required to do a breaking change in a non-breaking version. Let's just be very careful about that. We can say that we were using the conventions from the given date and then once they are stable we can provide the users an option to migrate to the new tags and deprecate the old ones but in a non aggressive way (e.g. we would remove the deprecated tags after 3-4 minor releases). Does it make any sense what I'm saying? :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1699688114
Yes its okay, we will add notes in our upgrade guides if tags are renamed, and can also do dual names to keep the deprecated for a number of releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697268496
I mean all components can be interesting to the users. Preferably we should ask the users what are they most interested in or which telemetry data they feel that they are currently missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697164399
Yes, I meant to ask if you have idea of what component decorators make more sense in your experience
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #11228:
URL: https://github.com/apache/camel/pull/11228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697079525
@marcingrzejszczak I'm looking at the span decorator available and I do think we could add some more. Do you have any suggestions on this particular task? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1699613829
@marcingrzejszczak that is a great idea - we should make these camel components use same convention if possible. I have created a JIRA: https://issues.apache.org/jira/browse/CAMEL-19812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697319503
Yes that would be good to have more of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1702224190
I think it would be beneficial to have a look at what we have as decorators today and do a little example to what we want to have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697353077
Another option would be to go through https://opentelemetry.io/docs/reference/specification/trace/semantic_conventions/ to see which conventions are defined today (remember that these are not stable so let's not ever say that we are OTel semantic convention compatible because if we do we will have to keep on doing breaking changes) and try to double check if our instrumentations are setting similar meta data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697271730
@davsclaus I do think this is could be a good approach (asking users) for improving the decorators' coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697271023
I think we should start by covering the most used ones (maybe the cloud services or messaging stuff), I will try to add some of them and open PRs. Thanks for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697078657
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #11228: Camel-Tracing: Removing NsqSpanDecorator since component is no more a…
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #11228:
URL: https://github.com/apache/camel/pull/11228#issuecomment-1697162024
@oscerd I don't exactly follow. What is the concrete question? Are you trying to add more span decorators?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org