[GitHub] [camel] orpiske commented on pull request #9939: CAMEL-17946 Introducing HTTPS support for AS2 component

["orpiske (via GitHub)" <gi...@apache.org>]

orpiske commented on PR #9939:
URL: https://github.com/apache/camel/pull/9939#issuecomment-1527617795

   > Thanks for working on this. I dont have time to go deep in the review until its more ready. At that time, it may be easier to create a new clean PR if this one ends up with too many comments, changes etc.
   
   I think it's mostly OK, but I think we need to avoid keeping data related to specific service instances on the internet (even more so for things that we don't have deep knowledge about). These things tend to rot very quickly - and we are still cleaning up stuff like this that was added in the past (!!!!). Which is why I have a -1 on this.
   
   So, as far as I am concerned, all it needs is to remove the service-specific bits and it should be ready to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org