[GitHub] [pinot] cto-junior commented on pull request #11458: [Flaky-test] Fix UpsertTableSegmentPreloadIntegrationTest

["cto-junior (via GitHub)" <gi...@apache.org>]

cto-junior commented on PR #11458:
URL: https://github.com/apache/pinot/pull/11458#issuecomment-1698427354

   Here we seem to be saying that even if snapshot exists for just 1 uploaded segment, we return true. 
   M motivation to ensure all segments had snapshot was to make sure the preload doesn't break in the future due to some unexpected changes in the snapshotting mechanism.
   
   We should atleast ensure all uploaded segments have snapshots


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org