You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2024/07/09 10:37:36 UTC
[PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
xuzifu666 opened a new pull request, #3714:
URL: https://github.com/apache/paimon/pull/3714
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #3714:
URL: https://github.com/apache/paimon/pull/3714#issuecomment-2220197570
By the way, since endwith has no range filtering capability, even we pass it to paimon, it has no filtering effect...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #3714:
URL: https://github.com/apache/paimon/pull/3714#discussion_r1672077369
##########
paimon-spark/paimon-spark-common/src/test/java/org/apache/paimon/spark/SparkFilterConverterTest.java:
##########
@@ -192,6 +210,11 @@ public void testDate() {
@Test
public void testIgnoreFailure() {
+ testStartsWith();
Review Comment:
OK，removed the ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3714:
URL: https://github.com/apache/paimon/pull/3714#discussion_r1671542229
##########
paimon-common/src/main/java/org/apache/paimon/predicate/EndsWith.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.predicate;
+
+import org.apache.paimon.data.BinaryString;
+import org.apache.paimon.types.DataType;
+
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * A {@link NullFalseLeafBinaryFunction} to evaluate {@code filter like '%abc' or filter like
+ * '_abc'}.
+ */
+public class EndsWith extends NullFalseLeafBinaryFunction {
+
+ public static final EndsWith INSTANCE = new EndsWith();
+
+ private EndsWith() {}
+
+ @Override
+ public boolean test(DataType type, Object field, Object patternLiteral) {
+ BinaryString fieldString = (BinaryString) field;
+ return fieldString.endsWith((BinaryString) patternLiteral);
+ }
+
+ @Override
+ public boolean test(
+ DataType type,
+ long rowCount,
+ Object min,
+ Object max,
+ Long nullCount,
+ Object patternLiteral) {
+ BinaryString minStr = (BinaryString) min;
+ BinaryString maxStr = (BinaryString) max;
+ BinaryString pattern = (BinaryString) patternLiteral;
+ return (minStr.endsWith(pattern) || minStr.compareTo(pattern) <= 0)
Review Comment:
Really works? Can you add more tests?
Endswith does not support range filtering very well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #3714:
URL: https://github.com/apache/paimon/pull/3714#discussion_r1671759896
##########
paimon-common/src/main/java/org/apache/paimon/predicate/EndsWith.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.predicate;
+
+import org.apache.paimon.data.BinaryString;
+import org.apache.paimon.types.DataType;
+
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * A {@link NullFalseLeafBinaryFunction} to evaluate {@code filter like '%abc' or filter like
+ * '_abc'}.
+ */
+public class EndsWith extends NullFalseLeafBinaryFunction {
+
+ public static final EndsWith INSTANCE = new EndsWith();
+
+ private EndsWith() {}
+
+ @Override
+ public boolean test(DataType type, Object field, Object patternLiteral) {
+ BinaryString fieldString = (BinaryString) field;
+ return fieldString.endsWith((BinaryString) patternLiteral);
+ }
+
+ @Override
+ public boolean test(
+ DataType type,
+ long rowCount,
+ Object min,
+ Object max,
+ Long nullCount,
+ Object patternLiteral) {
+ BinaryString minStr = (BinaryString) min;
+ BinaryString maxStr = (BinaryString) max;
+ BinaryString pattern = (BinaryString) patternLiteral;
+ return (minStr.endsWith(pattern) || minStr.compareTo(pattern) <= 0)
Review Comment:
OK，had add tests to test it. @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #3714:
URL: https://github.com/apache/paimon/pull/3714#discussion_r1672040317
##########
paimon-common/src/main/java/org/apache/paimon/predicate/EndsWith.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.predicate;
+
+import org.apache.paimon.data.BinaryString;
+import org.apache.paimon.types.DataType;
+
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * A {@link NullFalseLeafBinaryFunction} to evaluate {@code filter like '%abc' or filter like
+ * '_abc'}.
+ */
+public class EndsWith extends NullFalseLeafBinaryFunction {
+
+ public static final EndsWith INSTANCE = new EndsWith();
+
+ private EndsWith() {}
+
+ @Override
+ public boolean test(DataType type, Object field, Object patternLiteral) {
+ BinaryString fieldString = (BinaryString) field;
+ return fieldString.endsWith((BinaryString) patternLiteral);
+ }
+
+ @Override
+ public boolean test(
+ DataType type,
+ long rowCount,
+ Object min,
+ Object max,
+ Long nullCount,
+ Object patternLiteral) {
+ BinaryString minStr = (BinaryString) min;
+ BinaryString maxStr = (BinaryString) max;
+ BinaryString pattern = (BinaryString) patternLiteral;
+ return (minStr.endsWith(pattern) || minStr.compareTo(pattern) <= 0)
Review Comment:
+1 with @JingsongLi, does `endWith` really have any effect on range filtering?
##########
paimon-spark/paimon-spark-common/src/test/java/org/apache/paimon/spark/SparkFilterConverterTest.java:
##########
@@ -192,6 +210,11 @@ public void testDate() {
@Test
public void testIgnoreFailure() {
+ testStartsWith();
Review Comment:
No need modify this, this is only to test `convertIgnoreFailure`, regardless of the filter used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3714:
URL: https://github.com/apache/paimon/pull/3714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Support StringEndsWith filter in SparkFilterConverter [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #3714:
URL: https://github.com/apache/paimon/pull/3714#issuecomment-2220217637
can add test for partition filering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org