You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2020/10/18 09:59:35 UTC

[skywalking] branch comment created (now 55fce30)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch comment
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


      at 55fce30  Fix a comment

This branch includes the following new commits:

     new 55fce30  Fix a comment

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[skywalking] 01/01: Fix a comment

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch comment
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 55fce303fb0ab8ac35f97a2a97325436634e94e2
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Sun Oct 18 17:59:19 2020 +0800

    Fix a comment
---
 .../skywalking/oap/server/core/analysis/NodeType.java      | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java
index 30fe61d..80c14a4 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java
@@ -22,14 +22,13 @@ import org.apache.skywalking.apm.network.language.agent.v3.SpanLayer;
 import org.apache.skywalking.oap.server.core.UnexpectedException;
 
 /**
- * Node type describe which kind of node of Service or Network address represents to.
- * <p>
- * The value comes from 'org.apache.skywalking.apm.network.language.agent.SpanLayer' at first place, but most likely it
- * will extend and be used directly from different sources, such as Mesh.
+ * Node type describe which kind of node of Service or Network address represents to. The node with {@link #Normal} and
+ * {@link #Browser} type would be treated as an observed node.
  */
 public enum NodeType {
     /**
-     * <code>Unknown = 0;</code>
+     * <code>Normal = 0;</code>
+     * This node type would be treated as an observed node.
      */
     Normal(0),
     /**
@@ -54,6 +53,7 @@ public enum NodeType {
     Cache(5),
     /**
      * <code>Browser = 6;</code>
+     * This node type would be treated as an observed node.
      */
     Browser(6),
     /**
@@ -101,7 +101,7 @@ public enum NodeType {
     }
 
     /**
-     * Right now, spanLayerValue is exact same as NodeType value.
+     * @return the node type conjectured from the give span layer.
      */
     public static NodeType fromSpanLayerValue(SpanLayer spanLayer) {
         switch (spanLayer) {
@@ -120,7 +120,7 @@ public enum NodeType {
             case UNRECOGNIZED:
                 return Unrecognized;
             default:
-                throw new UnexpectedException("Unknown NodeType value");
+                throw new UnexpectedException("Can't transfer to the NodeType. SpanLayer=" + spanLayer);
         }
     }
 }