[GitHub] [cloudstack] ravening commented on a change in pull request #5862: KVM HA Enhancements for Ceph RBD Primary Storage

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #5862:
URL: https://github.com/apache/cloudstack/pull/5862#discussion_r836331826



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java
##########
@@ -32,9 +32,10 @@
     private static final Logger s_logger = Logger.getLogger(KVMHABase.class);
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
+    protected static String s_heartBeatPathRbd;
     protected long _heartBeatUpdateTimeout = 60000;
     protected long _heartBeatUpdateFreq = 60000;
-    protected long _heartBeatUpdateMaxTries = 5;
+    protected long _heartBeatUpdateMaxTries = 10;

Review comment:
       Instead of changing the existing value, is it better to use new variable for ceph?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org