[jira] [Commented] (MAPREDUCE-5660) Log info about possible thrashing (when using memory-based scheduling in Capacity Scheduler) is not printed

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836136#comment-13836136 ] 

Hadoop QA commented on MAPREDUCE-5660:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12616489/MAPREDUCE-5660.1.patch.txt
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4234//console

This message is automatically generated.

> Log info about possible thrashing (when using memory-based scheduling in Capacity Scheduler) is not printed
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5660
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5660
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: capacity-sched, mrv1, tasktracker
>    Affects Versions: 1.2.1
>            Reporter: Adam Kawa
>            Priority: Trivial
>         Attachments: MAPREDUCE-5660.1.patch.txt
>
>
> There is a tiny, but confusing when troubleshooting, bug in TaskTracker code:
> {code}
> if (totalMemoryAllottedForTasks > totalPhysicalMemoryOnTT) {
>   LOG.info("totalMemoryAllottedForTasks > totalPhysicalMemoryOnTT."
>       + " Thrashing might happen.");
> } else if (totalMemoryAllottedForTasks > totalVirtualMemoryOnTT) {
>   LOG.info("totalMemoryAllottedForTasks > totalVirtualMemoryOnTT."
>       + " Thrashing might happen.");
> }
> {code}
> totalMemoryAllottedForTasks is calculated in megabytes, while totalPhysicalMemoryOnTT (and totalVirtualMemoryOnTT) is calculated in bytes. totalMemoryAllottedForTasks should be converted to bytes for a correct comparison.



--
This message was sent by Atlassian JIRA
(v6.1#6144)