You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/20 00:43:20 UTC

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0
URL: https://github.com/apache/helix/pull/339#discussion_r305560197
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
 ##########
 @@ -431,9 +426,104 @@ public Response getClusterStateModelDefinition(@PathParam("clusterId") String cl
     StateModelDefinition stateModelDef =
         dataAccessor.getProperty(dataAccessor.keyBuilder().stateModelDef(statemodel));
 
+    if (stateModelDef == null) {
+      return  notFound();
 
 Review comment:
   Can we remove the extra space? It would be great to keep the code quality for open source :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services