You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2023/03/11 22:53:04 UTC
[GitHub] [arrow-datafusion] Jefffrey opened a new pull request, #5556: Revert describe count() workaround
Jefffrey opened a new pull request, #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Revert workaround applied by https://github.com/apache/arrow-datafusion/pull/5468 which is root cause fixed by https://github.com/apache/arrow-datafusion/pull/5485 now
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangzhx commented on a diff in pull request #5556: Revert describe count() workaround
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on code in PR #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556#discussion_r1133469247
##########
datafusion/core/src/dataframe.rs:
##########
@@ -332,45 +332,28 @@ impl DataFrame {
let original_schema_fields = self.schema().fields().iter();
//define describe column
- let mut describe_schemas = original_schema_fields
- .clone()
- .map(|field| {
- if field.data_type().is_numeric() {
- Field::new(field.name(), DataType::Float64, true)
- } else {
- Field::new(field.name(), DataType::Utf8, true)
- }
- })
- .collect::<Vec<_>>();
- describe_schemas.insert(0, Field::new("describe", DataType::Utf8, false));
+ let mut describe_schemas = vec![Field::new("describe", DataType::Utf8, false)];
+ describe_schemas.extend(original_schema_fields.clone().map(|field| {
Review Comment:
Learned from here.thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangzhx commented on pull request #5556: Revert describe count() workaround
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on PR #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556#issuecomment-1465476266
thanks ,i already push a pr for this.
https://github.com/apache/arrow-datafusion/pull/5565
i will close my pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangzhx commented on a diff in pull request #5556: Revert describe count() workaround
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on code in PR #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556#discussion_r1133469247
##########
datafusion/core/src/dataframe.rs:
##########
@@ -332,45 +332,28 @@ impl DataFrame {
let original_schema_fields = self.schema().fields().iter();
//define describe column
- let mut describe_schemas = original_schema_fields
- .clone()
- .map(|field| {
- if field.data_type().is_numeric() {
- Field::new(field.name(), DataType::Float64, true)
- } else {
- Field::new(field.name(), DataType::Utf8, true)
- }
- })
- .collect::<Vec<_>>();
- describe_schemas.insert(0, Field::new("describe", DataType::Utf8, false));
+ let mut describe_schemas = vec![Field::new("describe", DataType::Utf8, false)];
+ describe_schemas.extend(original_schema_fields.clone().map(|field| {
Review Comment:
Learned from here.thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5556: Revert describe count() workaround
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jefffrey commented on pull request #5556: Revert describe count() workaround
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556#issuecomment-1465044015
cc @jiangzhx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5556: Revert describe count() workaround
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556#issuecomment-1466409928
Benchmark runs are scheduled for baseline = 1a22f9fd436c9892566b668e535e0d6c8cb9fbd3 and contender = 9464bf2eb593ce239acf3823c5ecdc6760b15679. 9464bf2eb593ce239acf3823c5ecdc6760b15679 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c8ca23705520493a86bb39397ad28ba2...e421b2cf9f604e40bd80f53d22a00c74/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2cb371c72fba422ebc3e89d64ffaed8e...77bc05c05ea44641891455bd6313e64e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5cf4c32bb88a4857bdc91bd73e1bc90f...31c259a23d8941f987dee47dfb8f3064/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ce71ccbc0213426b8c71ca8819ab85d8...ed1d5e895ff448b5931f221009c55f4d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org