You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/02 10:59:53 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request, #37378: [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode
AngersZhuuuu opened a new pull request, #37378:
URL: https://github.com/apache/spark/pull/37378
### What changes were proposed in this pull request?
The current verbose string of LogicalPlan didn't contain join type, we should add this
```
(10) BroadcastHashJoin [codegen id : 4]
Left keys [1]: [ws_sold_date_sk#7]
Right keys [1]: [d_date_sk#9]
Join type: Inner
Join condition: None
```
### Why are the changes needed?
Add missed join type in verbose plan
### Does this PR introduce _any_ user-facing change?
User can see join type in verbose plan string
### How was this patch tested?
Existed UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37378: [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37378:
URL: https://github.com/apache/spark/pull/37378#issuecomment-1203407289
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #37378: [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #37378:
URL: https://github.com/apache/spark/pull/37378#issuecomment-1202334070
ping @HyukjinKwon @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37378: [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37378: [SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode
URL: https://github.com/apache/spark/pull/37378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org