You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/10/13 10:06:27 UTC

[GitHub] [guacamole-server] yaroslavNqualisystems commented on pull request #301: GUACAMOLE-1174: Added exec call implementation for kubernetes protocol

yaroslavNqualisystems commented on pull request #301:
URL: https://github.com/apache/guacamole-server/pull/301#issuecomment-707636507


   > @yaroslavNqualisystems, before I jump back in and re-review:
   > 
   > ![GUACAMOLE-1175: Fixes](https://user-images.githubusercontent.com/4632905/94103485-a96e3200-fde9-11ea-8d59-65aa58e4b10e.png)
   > 
   > Please update your commit message such that it reflects the high-level nature of your changes. If that forces the change to be split across multiple, logical commits, so much the better. The commit logs should serve as a useful reference for anyone that wants to discover the nature of changes made, what motivated those changes, etc.
   > 
   > A good (and amusing) reference on this: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/
   
   I have updated the commit message, I guess you can proceed with review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org