[GitHub] [airflow] uranusjr commented on a diff in pull request #29721: Make serde lazy-load dependent modules

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #29721:
URL: https://github.com/apache/airflow/pull/29721#discussion_r1116057525


##########
airflow/serialization/serde.py:
##########
@@ -270,38 +273,94 @@ def _stringify(classname: str, version: int, value: T | None) -> str:
     return s
 
 
-def _register():
-    """Register builtin serializers and deserializers for types that don't have any themselves"""
-    _serializers.clear()
-    _deserializers.clear()
-
-    for _, name, _ in iter_namespace(airflow.serialization.serializers):
-        name = import_module(name)
-        for s in getattr(name, "serializers", list()):
-            if not isinstance(s, str):
-                s = qualname(s)
-            if s in _serializers and _serializers[s] != name:
-                raise AttributeError(f"duplicate {s} for serialization in {name} and {_serializers[s]}")
-            log.debug("registering %s for serialization")
-            _serializers[s] = name
-        for d in getattr(name, "deserializers", list()):
-            if not isinstance(d, str):
-                d = qualname(d)
-            if d in _deserializers and _deserializers[d] != name:
-                raise AttributeError(f"duplicate {d} for deserialization in {name} and {_serializers[d]}")
-            log.debug("registering %s for deserialization", d)
-            _deserializers[d] = name
-            _extra_allowed.add(d)
-
-
-def _compile_patterns():
-    patterns = conf.get("core", "allowed_deserialization_classes").split()
-
-    _patterns.clear()  # ensure to reinit
-    for p in patterns:
-        p = re.sub(r"(\w)\.", r"\1\..", p)
-        _patterns.append(re.compile(p))
-
-
-_register()
-_compile_patterns()
+_AIRFLOW_SERIALIZERS = {
+    "decimal": {"Decimal": "airflow.serialization.serializers.bignum"},
+    "datetime": {
+        "date": "airflow.serialization.serializers.datetime",
+        "datetime": "airflow.serialization.serializers.datetime",
+        "timedelta": "airflow.serialization.serializers.datetime",
+    },
+    "kubernetes": {
+        "client.models.v1_resource_requirements.V1ResourceRequirements": (
+            "airflow.serialization.serializers.kubernetes"
+        ),
+        "client.models.v1_pod.V1Pod": "airflow.serialization.serializers.kubernetes",
+    },
+    "numpy": {
+        "bool_": "airflow.serialization.serializers.numpy",
+        "complex64": "airflow.serialization.serializers.numpy",
+        "complex128": "airflow.serialization.serializers.numpy",
+        "float16": "airflow.serialization.serializers.numpy",
+        "float64": "airflow.serialization.serializers.numpy",
+        "intc": "airflow.serialization.serializers.numpy",
+        "intp": "airflow.serialization.serializers.numpy",
+        "int8": "airflow.serialization.serializers.numpy",
+        "int16": "airflow.serialization.serializers.numpy",
+        "int32": "airflow.serialization.serializers.numpy",
+        "int64": "airflow.serialization.serializers.numpy",
+        "uint8": "airflow.serialization.serializers.numpy",
+        "uint16": "airflow.serialization.serializers.numpy",
+        "uint32": "airflow.serialization.serializers.numpy",
+        "uint64": "airflow.serialization.serializers.numpy",
+    },
+    "pendulum": {
+        "datetime.DateTime": "airflow.serialization.serializers.datetime",
+        "tz.timezone.FixedTimezone": "airflow.serialization.serializers.timezone",
+        "tz.timezone.Timezone": "airflow.serialization.serializers.timezone",
+    },
+}
+
+_AIRFLOW_DESERIALIZERS = {

Review Comment:
   Yes apparently, this is the case before the patch and I’m not sure why.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org