You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by bo...@apache.org on 2026/04/03 17:13:14 UTC

(grails-core) 05/05: fix: remove @PendingFeatureIf from many-to-many sorting test in H5

This is an automated email from the ASF dual-hosted git repository.

borinquenkid pushed a commit to branch 8.0.x-hibernate7-dev
in repository https://gitbox.apache.org/repos/asf/grails-core.git

commit 9c7993507981ca5d39765d9db2e5c5c2a413eb56
Author: Walter Duque de Estrada <wb...@mac.com>
AuthorDate: Fri Apr 3 12:10:59 2026 -0500

    fix: remove @PendingFeatureIf from many-to-many sorting test in H5
    
    The 'many-to-many queries with sorting do not throw exception' feature
    (issue #14636) now passes on Hibernate 5 as well. Remove the
    @PendingFeatureIf guard and the unused IgnoreIf/PendingFeatureIf imports.
    
    Co-authored-by: Copilot <22...@users.noreply.github.com>
---
 .../grails/gorm/specs/WhereQueryOldIssueVerificationSpec.groovy       | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/grails-data-hibernate5/core/src/test/groovy/grails/gorm/specs/WhereQueryOldIssueVerificationSpec.groovy b/grails-data-hibernate5/core/src/test/groovy/grails/gorm/specs/WhereQueryOldIssueVerificationSpec.groovy
index 0b3c835dde..a53128760d 100644
--- a/grails-data-hibernate5/core/src/test/groovy/grails/gorm/specs/WhereQueryOldIssueVerificationSpec.groovy
+++ b/grails-data-hibernate5/core/src/test/groovy/grails/gorm/specs/WhereQueryOldIssueVerificationSpec.groovy
@@ -18,9 +18,6 @@
  */
 package grails.gorm.tests
 
-import spock.lang.IgnoreIf
-import spock.lang.PendingFeatureIf
-
 import grails.gorm.annotation.Entity
 import grails.gorm.hibernate.HibernateEntity
 import grails.gorm.transactions.Rollback
@@ -160,7 +157,6 @@ class WhereQueryOldIssueVerificationSpec extends Specification {
 
     @Rollback
     @Issue('https://github.com/apache/grails-core/issues/14636')
-    @PendingFeatureIf({ System.getProperty('hibernate5.gorm.suite') })
     def "many-to-many queries with sorting do not throw exception"() {
         given: "users and roles in a many-to-many relationship"
         def role1 = new WqRole(name: "ADMIN").save(flush: true)