You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/06 07:38:25 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request, #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column
HappenLee opened a new pull request, #9408:
URL: https://github.com/apache/incubator-doris/pull/9408
# Proposed changes
Issue Number: close #9380
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9408:
URL: https://github.com/apache/incubator-doris/pull/9408#issuecomment-1127278950
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9408:
URL: https://github.com/apache/incubator-doris/pull/9408#discussion_r866696033
##########
be/src/vec/sink/vtablet_sink.h:
##########
@@ -102,6 +102,10 @@ class VOlapTableSink : public OlapTableSink {
Status _validate_data(RuntimeState* state, vectorized::Block* block, Bitmap* filter_bitmap,
int* filtered_rows, bool* stop_processing);
+ // some output column of output expr may have different nullable property with dest slot desc
+ // so here need to do the convert operation6
Review Comment:
```suggestion
// so here need to do the convert operation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee merged pull request #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column
Posted by GitBox <gi...@apache.org>.
HappenLee merged PR #9408:
URL: https://github.com/apache/incubator-doris/pull/9408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9408:
URL: https://github.com/apache/incubator-doris/pull/9408#issuecomment-1127278992
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9408: [Bug][Vectorized] Fix insert bimmap column with nullable column
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9408:
URL: https://github.com/apache/incubator-doris/pull/9408#issuecomment-1128462176
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org