Re: [PR] ORC-1767: [C++] Improve writing performance of encoded string column and support EncodedStringVectorBatch for StringColumnWriter [orc]

["taiyang-li (via GitHub)" <gi...@apache.org>]

taiyang-li commented on code in PR #2010:
URL: https://github.com/apache/orc/pull/2010#discussion_r1735741811


##########
c++/include/orc/Vector.hh:
##########
@@ -248,10 +254,16 @@ namespace orc {
     ~EncodedStringVectorBatch() override;
     std::string toString() const override;
     void resize(uint64_t capacity) override;
+
+    // Calculate data and length in StringVectorBatch from dictionary and index
+    void decodeDictionary() override;
+
     std::shared_ptr<StringDictionary> dictionary;
 
     // index for dictionary entry
     DataBuffer<int64_t> index;
+
+    std::atomic<bool> dictionaryDecoded{false};

Review Comment:
   It's a personal coding habit in case there might be a multi-threaded call scenario in the future. Besides, `std::atomic<bool>` is so trivial that it would not influence the performance. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org