You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/11 07:35:24 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #538: ESP32: Use
__asm__ __volatile__ for inline assembly
yamt opened a new pull request #538: ESP32: Use __asm__ __volatile__ for inline assembly
URL: https://github.com/apache/incubator-nuttx/pull/538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #538: ESP32: Use __asm__
__volatile__ for inline assembly
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly
URL: https://github.com/apache/incubator-nuttx/pull/538#issuecomment-597697575
@patacongo
here's my attempt. https://github.com/apache/incubator-nuttx/pull/533
please read the commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #538: ESP32: Use
__asm__ __volatile__ for inline assembly
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #538: ESP32: Use __asm__ __volatile__ for inline assembly
URL: https://github.com/apache/incubator-nuttx/pull/538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #538: ESP32: Use
__asm__ __volatile__ for inline assembly
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly
URL: https://github.com/apache/incubator-nuttx/pull/538#issuecomment-597656268
@yamt Do you want me to help out with the coding standard problems? I can fix them in a different PR. I ask because I do not want to collide with anything you are doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #538: ESP32: Use
__asm__ __volatile__ for inline assembly
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly
URL: https://github.com/apache/incubator-nuttx/pull/538#issuecomment-598990217
It looks like the nxstyle check is out of date. From looking at the file, only the mixed case names seem to be a reading coding standard problem. And those are ROM function prototypes that I suspect should not be changed anyway.
My inclination is to merge this now so that we can continue to make forward progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services