You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/29 05:05:05 UTC

[GitHub] [spark] zhengruifeng opened a new pull request #27037: [SPARK-30376][ML] Unify the computation of numFeatures

zhengruifeng opened a new pull request #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037
 
 
   ### What changes were proposed in this pull request?
   using `MetadataUtils.getNumFeatures` to extract the numFeatures
   
   ### Why are the changes needed?
   may avoid `first`/`head` job if metadata has attrGroup
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   existing testsuites
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569478626
 
 
   **[Test build #115905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115905/testReport)** for PR 27037 at commit [`90b4b4f`](https://github.com/apache/spark/commit/90b4b4feced6bf218837c75a79132f615514650a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569478657
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569478660
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115905/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569475417
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569475752
 
 
   **[Test build #115905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115905/testReport)** for PR 27037 at commit [`90b4b4f`](https://github.com/apache/spark/commit/90b4b4feced6bf218837c75a79132f615514650a).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569475417
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569475752
 
 
   **[Test build #115905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115905/testReport)** for PR 27037 at commit [`90b4b4f`](https://github.com/apache/spark/commit/90b4b4feced6bf218837c75a79132f615514650a).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569475420
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20695/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569475420
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20695/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569478660
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115905/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569565127
 
 
   Merged to master, thanks @srowen for reviewing!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27037: [SPARK-30376][ML] Unify the computation of numFeatures
URL: https://github.com/apache/spark/pull/27037#issuecomment-569478657
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org