You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Doğacan Güney (JIRA)" <ji...@apache.org> on 2008/10/19 15:52:50 UTC
[jira] Created: (HBASE-937) Thrift getRow does not support
specifying columns
Thrift getRow does not support specifying columns
-------------------------------------------------
Key: HBASE-937
URL: https://issues.apache.org/jira/browse/HBASE-937
Project: Hadoop HBase
Issue Type: Improvement
Components: thrift
Reporter: Doğacan Güney
Priority: Minor
Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641997#action_12641997 ]
stack commented on HBASE-937:
-----------------------------
TestThriftServer fails when I apply this patch. Does it for you Doğacan?
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: thrift_getrow.patch, thrift_getrow_v2.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642168#action_12642168 ]
Doğacan Güney commented on HBASE-937:
-------------------------------------
Yeah, you are right. I didn't realize that there is a test for thrift in trunk (I can't find it in 0.18.0). I will send a new patch that fixes a silly copy/paste error and updates test case.
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: thrift_getrow.patch, thrift_getrow_v2.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated HBASE-937:
--------------------------------
Attachment: thrift_getrow.patch
Patch for the issue.
There is some noise diffs in Hbase.java but I think I got it right.
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: thrift_getrow.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-937:
---------------------------
Assignee: Doğacan Güney
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: thrift_getrow.patch, thrift_getrow_v2.patch, thrift_getrow_v3.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-937.
-------------------------
Resolution: Fixed
Fix Version/s: 0.19.0
Committed. Thanks for the patch Doğacan
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: thrift_getrow.patch, thrift_getrow_v2.patch, thrift_getrow_v3.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated HBASE-937:
--------------------------------
Attachment: thrift_getrow_v2.patch
Yes, it works for me but only against 0.18.0. For some reason, I can't get trunk to work at all.
Here is an updated patch with documentation fixes.
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: thrift_getrow.patch, thrift_getrow_v2.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641115#action_12641115 ]
stack commented on HBASE-937:
-----------------------------
Looks good to me Doğacan. Did you try it? Does it work for you?
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: thrift_getrow.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-937) Thrift getRow does not support
specifying columns
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated HBASE-937:
--------------------------------
Attachment: thrift_getrow_v3.patch
Yet another patch. Fixes copy/paste error and updates TestThriftServer to also test the new methods.
> Thrift getRow does not support specifying columns
> -------------------------------------------------
>
> Key: HBASE-937
> URL: https://issues.apache.org/jira/browse/HBASE-937
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: thrift_getrow.patch, thrift_getrow_v2.patch, thrift_getrow_v3.patch
>
>
> Thrift interface has a getRow function but it does not support asking for specific columns.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.