You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/20 17:08:10 UTC
Review Request 72794: Added a test for discarding image pull on
discard of getting image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72794/
-----------------------------------------------------------
Review request for mesos and Qian Zhang.
Bugs: MESOS-10169
https://issues.apache.org/jira/browse/MESOS-10169
Repository: mesos
Description
-------
This test checks that when all futures returned by docker store's
`get()` that are pending image pull are discarded by the callers,
the pull future (returned by the puller to the store) is discarded
by the store as well.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc
Diff: https://reviews.apache.org/r/72794/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72794: Added a test for discarding image pull on
discard of getting image.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72794/#review221669
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72790, 72791, 72792, 72793, 72794]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Aug. 20, 2020, 5:08 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72794/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2020, 5:08 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-10169
> https://issues.apache.org/jira/browse/MESOS-10169
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that when all futures returned by docker store's
> `get()` that are pending image pull are discarded by the callers,
> the pull future (returned by the puller to the store) is discarded
> by the store as well.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc
>
>
> Diff: https://reviews.apache.org/r/72794/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72794: Added a test for discarding image pull on
discard of getting image.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72794/#review221792
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/tests/containerizer/provisioner_docker_tests.cpp
Lines 437-438 (patched)
<https://reviews.apache.org/r/72794/#comment310868>
A newline between.
- Qian Zhang
On Aug. 21, 2020, 1:08 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72794/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2020, 1:08 a.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-10169
> https://issues.apache.org/jira/browse/MESOS-10169
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that when all futures returned by docker store's
> `get()` that are pending image pull are discarded by the callers,
> the pull future (returned by the puller to the store) is discarded
> by the store as well.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc
>
>
> Diff: https://reviews.apache.org/r/72794/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>