You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/09/24 18:37:49 UTC
[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11500
Change subject: Ignore auto-generated sentry-site*.xml
......................................................................
Ignore auto-generated sentry-site*.xml
IMPALA-7074 introduced few new generated sentry-site*.xml files and
those generated files should be in .gitignore.
Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
---
M fe/src/test/resources/.gitignore
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/11500/1
--
To view, visit http://gerrit.cloudera.org:8080/11500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11500 )
Change subject: Ignore auto-generated sentry-site*.xml
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3205/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 18:42:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11500 )
Change subject: Ignore auto-generated sentry-site*.xml
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/761/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 19:25:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11500 )
Change subject: Ignore auto-generated sentry-site*.xml
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 22:24:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11500 )
Change subject: Ignore auto-generated sentry-site*.xml
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Sep 2018 18:39:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ignore auto-generated sentry-site*.xml
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11500 )
Change subject: Ignore auto-generated sentry-site*.xml
......................................................................
Ignore auto-generated sentry-site*.xml
IMPALA-7074 introduced few new generated sentry-site*.xml files and
those generated files should be in .gitignore.
Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Reviewed-on: http://gerrit.cloudera.org:8080/11500
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/resources/.gitignore
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I788efdac1112cdfd029a79412ffa91fd391af53a
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>