You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/02/22 23:23:30 UTC
[GitHub] [activemq] artpdr opened a new pull request #778: Fix TempUsage memory leak
artpdr opened a new pull request #778:
URL: https://github.com/apache/activemq/pull/778
If you have an application that creates lots of queues it will eventually
fail with OOM because TempUsage is started on Queue#start but never stopped.
The `systemUsage.getTempUsage().start()` used on the Queue#start
adds elements on a List from TempUsage parent and these elements
are never removed.
To reproduce this issue you need to leave an application
running for a long time creating different queues.
The only way to avoid the leak right now is to stop the BrokerService,
which isn't a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] cshannon commented on pull request #778: Fix TempUsage memory leak
Posted by GitBox <gi...@apache.org>.
cshannon commented on pull request #778:
URL: https://github.com/apache/activemq/pull/778#issuecomment-1048705020
Thanks for the PR, this looks like a good catch. A couple things: Pull requests should have a Jira associated with it describing the issue. https://issues.apache.org/jira/projects/AMQ . Also, ideally it would be good to include a unit test that can demonstrate the issue and show that it's fixed.
In this case I'll create the Jira as I am going to re-work the fix slightly and I will a test real quick because we are about to do a new release but for the future you can keep that in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] artpdr commented on pull request #778: Fix TempUsage memory leak
Posted by GitBox <gi...@apache.org>.
artpdr commented on pull request #778:
URL: https://github.com/apache/activemq/pull/778#issuecomment-1048756018
Thanks a lot @cshannon. Good point on the testing part... I didn't include the test because I didn't find any test for that class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] cshannon commented on pull request #778: Fix TempUsage memory leak
Posted by GitBox <gi...@apache.org>.
cshannon commented on pull request #778:
URL: https://github.com/apache/activemq/pull/778#issuecomment-1048746334
@artpdr - I amended/merged your commit and updated some tests. https://issues.apache.org/jira/browse/AMQ-8509
https://github.com/apache/activemq/commit/d1e9ba68b3cbea3e9294cf4993d005c3c8ea86f2
Thanks again for catching that, this will go into 5.17.0 and 5.16.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] cshannon edited a comment on pull request #778: Fix TempUsage memory leak
Posted by GitBox <gi...@apache.org>.
cshannon edited a comment on pull request #778:
URL: https://github.com/apache/activemq/pull/778#issuecomment-1048705020
Thanks for the PR, this looks like a good catch. A couple things: Pull requests should have a Jira associated with it describing the issue. https://issues.apache.org/jira/projects/AMQ . Also, ideally it would be good to include a unit test that can demonstrate the issue and show that it's fixed.
In this case I'll create the Jira as I am going to re-work the fix slightly by adding a test real quick because we are about to do a new release but for the future you can keep that in mind.
Seems like this issue is due to: [AMQ-7085](https://issues.apache.org/jira/browse/AMQ-7085)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] artpdr commented on pull request #778: Fix TempUsage memory leak
Posted by GitBox <gi...@apache.org>.
artpdr commented on pull request #778:
URL: https://github.com/apache/activemq/pull/778#issuecomment-1048341655
Guys can you take a look at this. This issue requires a server restart from time to time to avoid an application OOM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] asfgit closed pull request #778: Fix TempUsage memory leak
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #778:
URL: https://github.com/apache/activemq/pull/778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org