You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by ak...@apache.org on 2004/03/20 05:03:12 UTC
svn commit: rev 9647 - in incubator/directory/eve/trunk/eve/frontend: buffer/spi/src/java/org/apache/eve/buffer decoder/pojo-impl decoder/pojo-impl/src/java/org/apache/eve/decoder/impl decoder/spi decoder/spi/src/java/org/apache/eve/decoder input/spi input/spi/src/java/org/apache/eve/input listener/spi listener/spi/src/java/org/apache/eve/listener
Author: akarasulu
Date: Fri Mar 19 20:03:12 2004
New Revision: 9647
Modified:
incubator/directory/eve/trunk/eve/frontend/buffer/spi/src/java/org/apache/eve/buffer/BufferPoolMonitorAdapter.java
incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/project.xml
incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/src/java/org/apache/eve/decoder/impl/DefaultDecoderManager.java
incubator/directory/eve/trunk/eve/frontend/decoder/spi/project.xml
incubator/directory/eve/trunk/eve/frontend/decoder/spi/src/java/org/apache/eve/decoder/DecoderManagerMonitorAdapter.java
incubator/directory/eve/trunk/eve/frontend/input/spi/project.xml
incubator/directory/eve/trunk/eve/frontend/input/spi/src/java/org/apache/eve/input/InputManagerMonitorAdapter.java
incubator/directory/eve/trunk/eve/frontend/listener/spi/project.xml
incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitorAdapter.java
Log:
Ok there were some major pitfall discoveries I've made regarding monitors.
Basically they should do as little as possible to effect the code that
they monitor. It's got alot to do with Heisenberg Uncertainty principle:
measuring something changes it so keep what you do while measuring down
to a minimum.
Monitors should
- never modify control flow or set variables that do
- never throw exceptions
- never return any values
Don't mess with monitors cuz they'll mess with you! I learned that the
hard way and cleaned up all the monitors that did stupid stuff that falls
in line with the above.
Alex
Modified: incubator/directory/eve/trunk/eve/frontend/buffer/spi/src/java/org/apache/eve/buffer/BufferPoolMonitorAdapter.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/buffer/spi/src/java/org/apache/eve/buffer/BufferPoolMonitorAdapter.java (original)
+++ incubator/directory/eve/trunk/eve/frontend/buffer/spi/src/java/org/apache/eve/buffer/BufferPoolMonitorAdapter.java Fri Mar 19 20:03:12 2004
@@ -1,52 +1,19 @@
/*
-
- ============================================================================
- The Apache Software License, Version 1.1
- ============================================================================
-
- Copyright (C) 1999-2002 The Apache Software Foundation. All rights reserved.
-
- Redistribution and use in source and binary forms, with or without modifica-
- tion, are permitted provided that the following conditions are met:
-
- 1. Redistributions of source code must retain the above copyright notice,
- this list of conditions and the following disclaimer.
-
- 2. Redistributions in binary form must reproduce the above copyright notice,
- this list of conditions and the following disclaimer in the documentation
- and/or other materials provided with the distribution.
-
- 3. The end-user documentation included with the redistribution, if any, must
- include the following acknowledgment: "This product includes software
- developed by the Apache Software Foundation (http://www.apache.org/)."
- Alternately, this acknowledgment may appear in the software itself, if
- and wherever such third-party acknowledgments normally appear.
-
- 4. The names "Eve Directory Server", "Apache Directory Project", "Apache Eve"
- and "Apache Software Foundation" must not be used to endorse or promote
- products derived from this software without prior written
- permission. For written permission, please contact apache@apache.org.
-
- 5. Products derived from this software may not be called "Apache", nor may
- "Apache" appear in their name, without prior written permission of the
- Apache Software Foundation.
-
- THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES,
- INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
- FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- APACHE SOFTWARE FOUNDATION OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
- INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLU-
- DING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
- OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
- This software consists of voluntary contributions made by many individuals
- on behalf of the Apache Software Foundation. For more information on the
- Apache Software Foundation, please see <http://www.apache.org/>.
-
-*/
+ * Copyright 2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
package org.apache.eve.buffer ;
@@ -57,8 +24,8 @@
* A BufferPoolMonitor adapter to extend to monitor only those signals that
* are of interest.
*
- * @author <a href="mailto:akarasulu@apache.org">Alex Karasulu</a>
- * @author $Author$
+ * @author <a href="mailto:directory-dev@incubator.apache.org">
+ * Apache Directory Project</a>
* @version $Rev$
*/
public class BufferPoolMonitorAdapter implements BufferPoolMonitor
Modified: incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/project.xml
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/project.xml (original)
+++ incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/project.xml Fri Mar 19 20:03:12 2004
@@ -50,7 +50,7 @@
<dependency>
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
- <version>SNAPSHOT</version>
+ <version>2.0</version>
<url>http://jakarta.apache.org/commons/lang</url>
</dependency>
Modified: incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/src/java/org/apache/eve/decoder/impl/DefaultDecoderManager.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/src/java/org/apache/eve/decoder/impl/DefaultDecoderManager.java (original)
+++ incubator/directory/eve/trunk/eve/frontend/decoder/pojo-impl/src/java/org/apache/eve/decoder/impl/DefaultDecoderManager.java Fri Mar 19 20:03:12 2004
@@ -28,6 +28,7 @@
import org.apache.eve.event.InputEvent ;
import org.apache.eve.seda.StageConfig ;
+import org.apache.eve.seda.StderrLoggingStageMonitor;
import org.apache.eve.event.EventRouter ;
import org.apache.eve.seda.DefaultStage ;
import org.apache.eve.listener.ClientKey ;
@@ -84,6 +85,7 @@
this.router = router ;
this.monitor = new DecoderManagerMonitorAdapter() ;
+ super.setMonitor( new StderrLoggingStageMonitor( getClass() ) ) ;
router.subscribe( InputEvent.class, this ) ;
router.subscribe( ConnectEvent.class, this ) ;
Modified: incubator/directory/eve/trunk/eve/frontend/decoder/spi/project.xml
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/decoder/spi/project.xml (original)
+++ incubator/directory/eve/trunk/eve/frontend/decoder/spi/project.xml Fri Mar 19 20:03:12 2004
@@ -26,6 +26,13 @@
</dependency>
<dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>2.0</version>
+ <url>http://jakarta.apache.org/commons/lang</url>
+ </dependency>
+
+ <dependency>
<groupId>incubator-directory</groupId>
<artifactId>codec-stateful</artifactId>
<version>SNAPSHOT</version>
Modified: incubator/directory/eve/trunk/eve/frontend/decoder/spi/src/java/org/apache/eve/decoder/DecoderManagerMonitorAdapter.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/decoder/spi/src/java/org/apache/eve/decoder/DecoderManagerMonitorAdapter.java (original)
+++ incubator/directory/eve/trunk/eve/frontend/decoder/spi/src/java/org/apache/eve/decoder/DecoderManagerMonitorAdapter.java Fri Mar 19 20:03:12 2004
@@ -19,6 +19,8 @@
import java.util.EventObject ;
+import org.apache.commons.lang.exception.ExceptionUtils ;
+
import org.apache.eve.event.Subscriber ;
@@ -40,6 +42,6 @@
public void
failedOnInform( Subscriber subscriber, EventObject event, Throwable t )
{
- throw new RuntimeException( t ) ;
+ System.out.println( ExceptionUtils.getFullStackTrace( t ) ) ;
}
}
Modified: incubator/directory/eve/trunk/eve/frontend/input/spi/project.xml
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/input/spi/project.xml (original)
+++ incubator/directory/eve/trunk/eve/frontend/input/spi/project.xml Fri Mar 19 20:03:12 2004
@@ -1,51 +1,58 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
<project>
- <extend>${basedir}/../../../project.xml</extend>
- <groupId>incubator-directory</groupId>
- <id>eve-frontend-input-spi</id>
+ <extend>${basedir}/../../../project.xml</extend>
+ <groupId>incubator-directory</groupId>
+ <id>eve-frontend-input-spi</id>
- <name>Eve Frontend Input Manager SPI</name>
- <package>org.apache.eve.input</package>
- <currentVersion>SNAPSHOT</currentVersion>
- <inceptionYear>2003</inceptionYear>
+ <name>Eve Frontend Input Manager SPI</name>
+ <package>org.apache.eve.input</package>
+ <currentVersion>SNAPSHOT</currentVersion>
+ <inceptionYear>2003</inceptionYear>
- <shortDescription>
+ <shortDescription>
Client input manager SPI used by Eve's frontend
- </shortDescription>
+ </shortDescription>
- <description>
+ <description>
Service interfaces for building an input manager that reads client
- input from a socket channel.
- </description>
+ input from a socket channel.
+ </description>
- <dependencies>
- <dependency>
- <groupId>avalon-framework</groupId>
- <artifactId>avalon-framework-api</artifactId>
- <version>4.1.5</version>
- <url>http://avalon.apache.org/framework</url>
- </dependency>
+ <dependencies>
+ <dependency>
+ <groupId>avalon-framework</groupId>
+ <artifactId>avalon-framework-api</artifactId>
+ <version>4.1.5</version>
+ <url>http://avalon.apache.org/framework</url>
+ </dependency>
- <dependency>
- <groupId>incubator-directory</groupId>
- <artifactId>eve-frontend-common-api</artifactId>
- <version>SNAPSHOT</version>
- <url>http://directory.apache.org/eve/frontend/common/api</url>
- </dependency>
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>2.0</version>
+ <url>http://jakarta.apache.org/commons/lang</url>
+ </dependency>
+
+ <dependency>
+ <groupId>incubator-directory</groupId>
+ <artifactId>eve-frontend-common-api</artifactId>
+ <version>SNAPSHOT</version>
+ <url>http://directory.apache.org/eve/frontend/common/api</url>
+ </dependency>
- <dependency>
- <groupId>incubator-directory</groupId>
- <artifactId>eve-frontend-buffer-spi</artifactId>
- <version>SNAPSHOT</version>
- <url>http://directory.apache.org/eve/frontend/buffer/spi</url>
- </dependency>
+ <dependency>
+ <groupId>incubator-directory</groupId>
+ <artifactId>eve-frontend-buffer-spi</artifactId>
+ <version>SNAPSHOT</version>
+ <url>http://directory.apache.org/eve/frontend/buffer/spi</url>
+ </dependency>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>3.8.1</version>
- <url>http://junit.org</url>
- </dependency>
- </dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>3.8.1</version>
+ <url>http://junit.org</url>
+ </dependency>
+ </dependencies>
</project>
Modified: incubator/directory/eve/trunk/eve/frontend/input/spi/src/java/org/apache/eve/input/InputManagerMonitorAdapter.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/input/spi/src/java/org/apache/eve/input/InputManagerMonitorAdapter.java (original)
+++ incubator/directory/eve/trunk/eve/frontend/input/spi/src/java/org/apache/eve/input/InputManagerMonitorAdapter.java Fri Mar 19 20:03:12 2004
@@ -24,6 +24,8 @@
import java.nio.channels.SelectionKey ;
import java.nio.channels.SocketChannel ;
+import org.apache.commons.lang.exception.ExceptionUtils ;
+
import org.apache.eve.ResourceException ;
import org.apache.eve.buffer.BufferPool ;
import org.apache.eve.listener.ClientKey ;
@@ -82,6 +84,7 @@
*/
public void selectFailure( Selector selector, IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -92,6 +95,7 @@
*/
public void keyExpiryFailure( ClientKey key, KeyExpiryException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -101,6 +105,7 @@
*/
public void readFailed( ClientKey key, IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -111,6 +116,7 @@
*/
public void bufferUnavailable( BufferPool bp, ResourceException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -122,6 +128,7 @@
public void channelRegistrationFailure( Selector selector,
SocketChannel channel, int key, IOException fault)
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -132,6 +139,7 @@
public void channelCloseFailure( SocketChannel channel,
IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
Modified: incubator/directory/eve/trunk/eve/frontend/listener/spi/project.xml
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/listener/spi/project.xml (original)
+++ incubator/directory/eve/trunk/eve/frontend/listener/spi/project.xml Fri Mar 19 20:03:12 2004
@@ -1,46 +1,53 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
<project>
- <extend>${basedir}/../../../project.xml</extend>
- <groupId>incubator-directory</groupId>
- <id>eve-frontend-listener-spi</id>
+ <extend>${basedir}/../../../project.xml</extend>
+ <groupId>incubator-directory</groupId>
+ <id>eve-frontend-listener-spi</id>
- <name>Eve Frontend Listener SPI</name>
- <package>org.apache.eve.listener</package>
- <currentVersion>SNAPSHOT</currentVersion>
- <inceptionYear>2003</inceptionYear>
+ <name>Eve Frontend Listener SPI</name>
+ <package>org.apache.eve.listener</package>
+ <currentVersion>SNAPSHOT</currentVersion>
+ <inceptionYear>2003</inceptionYear>
- <shortDescription>
+ <shortDescription>
Socket listener SPI used by Eve's frontend
- </shortDescription>
+ </shortDescription>
- <description>
+ <description>
Eve's Listener manager interface is responsible for adding and
removing listeners that bind to ports on server interfaces to
accept incoming client connections. The interface exposes methods
to dynamically bind and unbind these server sockets.
- </description>
+ </description>
- <dependencies>
- <dependency>
- <groupId>avalon-framework</groupId>
- <artifactId>avalon-framework-api</artifactId>
- <version>4.1.5</version>
- <url>http://avalon.apache.org/framework</url>
- </dependency>
+ <dependencies>
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>2.0</version>
+ <url>http://jakarta.apache.org/commons/lang</url>
+ </dependency>
+
+ <dependency>
+ <groupId>avalon-framework</groupId>
+ <artifactId>avalon-framework-api</artifactId>
+ <version>4.1.5</version>
+ <url>http://avalon.apache.org/framework</url>
+ </dependency>
- <dependency>
- <groupId>incubator-directory</groupId>
- <artifactId>eve-frontend-common-api</artifactId>
- <version>SNAPSHOT</version>
- <url>http://directory.apache.org/eve/frontend/common/api</url>
- </dependency>
+ <dependency>
+ <groupId>incubator-directory</groupId>
+ <artifactId>eve-frontend-common-api</artifactId>
+ <version>SNAPSHOT</version>
+ <url>http://directory.apache.org/eve/frontend/common/api</url>
+ </dependency>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>3.8.1</version>
- <url>http://junit.org</url>
- </dependency>
- </dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>3.8.1</version>
+ <url>http://junit.org</url>
+ </dependency>
+ </dependencies>
</project>
Modified: incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitorAdapter.java
==============================================================================
--- incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitorAdapter.java (original)
+++ incubator/directory/eve/trunk/eve/frontend/listener/spi/src/java/org/apache/eve/listener/ListenerManagerMonitorAdapter.java Fri Mar 19 20:03:12 2004
@@ -21,13 +21,15 @@
import java.nio.channels.Selector ;
import java.nio.channels.SelectionKey ;
+import org.apache.commons.lang.exception.ExceptionUtils ;
+
/**
* Null adapter for the ListenerManagerMonitor.
*
- * @author <a href="mailto:akarasulu@apache.org">Alex Karasulu</a>
- * @author $Author: akarasulu $
- * @version $Rev: 6456 $
+ * @author <a href="mailto:directory-dev@incubator.apache.org">
+ * Apache Directory Project</a>
+ * @version $Rev$
*/
public class ListenerManagerMonitorAdapter implements ListenerManagerMonitor
{
@@ -53,7 +55,7 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#bindOccured(
* org.apache.eve.listener.ServerListener)
*/
- public void bindOccured( ServerListener a_listener )
+ public void bindOccured( ServerListener listener )
{
}
@@ -62,7 +64,7 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#unbindOccured(
* org.apache.eve.listener.ServerListener)
*/
- public void unbindOccured( ServerListener a_listener )
+ public void unbindOccured( ServerListener listener )
{
}
@@ -72,7 +74,7 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#acceptOccured(
* java.nio.channels.SelectionKey)
*/
- public void acceptOccured( SelectionKey a_key )
+ public void acceptOccured( SelectionKey key )
{
}
@@ -82,7 +84,7 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#selectOccured(
* java.nio.channels.Selector)
*/
- public void selectOccured( Selector a_selector )
+ public void selectOccured( Selector selector )
{
}
@@ -91,8 +93,9 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#failedToBind(
* org.apache.eve.listener.ServerListener, java.io.IOException)
*/
- public void failedToBind( ServerListener a_listener, IOException a_failure )
+ public void failedToBind( ServerListener listener, IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -100,9 +103,10 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#failedToUnbind(
* org.apache.eve.listener.ServerListener, java.io.IOException)
*/
- public void failedToUnbind( ServerListener a_listener,
- IOException a_failure )
+ public void failedToUnbind( ServerListener listener,
+ IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -110,8 +114,9 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#failedToExpire(
* org.apache.eve.listener.ClientKey, java.io.IOException)
*/
- public void failedToExpire( ClientKey a_key, IOException a_failure )
+ public void failedToExpire( ClientKey key, IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -119,8 +124,9 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#failedToAccept(
* java.nio.channels.SelectionKey, java.io.IOException)
*/
- public void failedToAccept( SelectionKey a_key, IOException a_failure )
+ public void failedToAccept( SelectionKey key, IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -128,8 +134,9 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#failedToSelect(
* java.nio.channels.Selector, java.io.IOException)
*/
- public void failedToSelect( Selector a_selector, IOException a_failure )
+ public void failedToSelect( Selector selector, IOException fault )
{
+ System.err.println( ExceptionUtils.getFullStackTrace( fault ) ) ;
}
@@ -137,7 +144,7 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#selectTimedOut(
* java.nio.channels.Selector)
*/
- public void selectTimedOut(Selector a_a_selector)
+ public void selectTimedOut( Selector selector )
{
}
@@ -146,7 +153,7 @@
* @see org.apache.eve.listener.ListenerManagerMonitor#enteringSelect(
* java.nio.channels.Selector)
*/
- public void enteringSelect( Selector a_selector )
+ public void enteringSelect( Selector selector )
{
}
}