You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/07/05 23:09:00 UTC

[jira] [Commented] (HBASE-18108) Procedure WALs are archived but not cleaned; fix

    [ https://issues.apache.org/jira/browse/HBASE-18108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075591#comment-16075591 ] 

stack commented on HBASE-18108:
-------------------------------

So, we already have a WAL cleaner for the general RegionServer WALs. Can we adapt this WAL cleaner to also harvest old Pv2 Master WALs? It would be a pity running yet another chore/thread in master -- one for RegionServer WALs and then another for the master procedure WALs?

As the master runs it creates procedure WALs. When the procedure system is done w/ them, it moves them to an archive dir. This archive dir was a hack up so feel free to rename or relocate it.  The idea is that after some configurable amount of time had passed, then the master procedure wals in the archive would be deleted... as they are for the regionserver WALs.

> Procedure WALs are archived but not cleaned; fix
> ------------------------------------------------
>
>                 Key: HBASE-18108
>                 URL: https://issues.apache.org/jira/browse/HBASE-18108
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> The Procedure WAL files used to be deleted when done. HBASE-14614 keeps them around in case issue but what is missing is a GC for no-longer-needed WAL files. This one is pretty important.
> From WALProcedureStore Cleaner TODO in https://docs.google.com/document/d/1eVKa7FHdeoJ1-9o8yZcOTAQbv0u0bblBlCCzVSIn69g/edit#heading=h.r2pc835nb7vi



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)