You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Noe-Payne, Erin A." <er...@mitre.org> on 2013/02/13 23:09:05 UTC
Patches, github, and review board
I have submitted a pull request through github (https://github.com/apache/rave/pull/1) to rave, related to issue 886 (https://issues.apache.org/jira/browse/RAVE-886).
In this case do I need to still fill out a review board request? It appears that the review board will not accept a diff file generated from the git repository. Can the review be performed through github, or is this an issue of review board configuration for the project?
Erin
Re: Patches, github, and review board
Posted by Matt Franklin <m....@gmail.com>.
On Wednesday, February 13, 2013, Chris Geer wrote:
> On Wed, Feb 13, 2013 at 3:09 PM, Noe-Payne, Erin A. <erinnp@mitre.org<javascript:;>
> >wrote:
>
> > I have submitted a pull request through github (
> > https://github.com/apache/rave/pull/1) to rave, related to issue 886 (
> > https://issues.apache.org/jira/browse/RAVE-886).
> >
> > In this case do I need to still fill out a review board request? It
> > appears that the review board will not accept a diff file generated from
> > the git repository. Can the review be performed through github, or is
> this
> > an issue of review board configuration for the project?
> >
>
> I'm ok skipping review board. What do others think?
The value of review board is the inline commenting. Github offers similar
features. I am OK with having separate SVN and git processes. IMO, both
workflows should be documented on the site though.
> >
> > Erin
> >
>
Re: Patches, github, and review board
Posted by Chris Geer <ch...@cxtsoftware.com>.
On Wed, Feb 13, 2013 at 3:09 PM, Noe-Payne, Erin A. <er...@mitre.org>wrote:
> I have submitted a pull request through github (
> https://github.com/apache/rave/pull/1) to rave, related to issue 886 (
> https://issues.apache.org/jira/browse/RAVE-886).
>
> In this case do I need to still fill out a review board request? It
> appears that the review board will not accept a diff file generated from
> the git repository. Can the review be performed through github, or is this
> an issue of review board configuration for the project?
>
I'm ok skipping review board. What do others think?
>
> Erin
>