You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/08 18:29:46 UTC
Re: Review Request 42842: Fixed flakiness in
ContainerLoggerTest.DefaultToSandbox
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 9:29 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian Qiu.
Bugs: MESOS-4615
https://issues.apache.org/jira/browse/MESOS-4615
Repository: mesos
Description
-------
The test needs to wait for the task to finish before examining the resulting files.
Diffs
-----
src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491
Diff: https://reviews.apache.org/r/42842/diff/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 42842: Fixed flakiness in
ContainerLoggerTest.DefaultToSandbox.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/#review118689
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 10, 2016, 5:49 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42842/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 5:49 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian Qiu.
>
>
> Bugs: MESOS-4615
> https://issues.apache.org/jira/browse/MESOS-4615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test needs to wait for the task to finish before examining the resulting files.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491
>
> Diff: https://reviews.apache.org/r/42842/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42842: Fixed flakiness in
ContainerLoggerTest.DefaultToSandbox.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/#review119461
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Feb. 10, 2016, 9:49 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42842/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 9:49 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian Qiu.
>
>
> Bugs: MESOS-4615
> https://issues.apache.org/jira/browse/MESOS-4615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test needs to wait for the task to finish before examining the resulting files.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491
>
> Diff: https://reviews.apache.org/r/42842/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42842: Fixed flakiness in
ContainerLoggerTest.DefaultToSandbox.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 9:49 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian Qiu.
Summary (updated)
-----------------
Fixed flakiness in ContainerLoggerTest.DefaultToSandbox.
Bugs: MESOS-4615
https://issues.apache.org/jira/browse/MESOS-4615
Repository: mesos
Description
-------
The test needs to wait for the task to finish before examining the resulting files.
Diffs
-----
src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491
Diff: https://reviews.apache.org/r/42842/diff/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 42842: Fixed flakiness in
ContainerLoggerTest.DefaultToSandbox
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42842/#review118274
-----------------------------------------------------------
Bad patch!
Reviews applied: [42842]
Failed command: ./support/apply-review.sh -n -r 42842
Error:
2016-02-08 19:14:42 URL:https://reviews.apache.org/r/42842/diff/raw/ [1788/1788] -> "42842.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must end in a period.
Full log: https://builds.apache.org/job/mesos-reviewbot/11326/console
- Mesos ReviewBot
On Feb. 8, 2016, 5:29 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42842/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 5:29 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Jian Qiu.
>
>
> Bugs: MESOS-4615
> https://issues.apache.org/jira/browse/MESOS-4615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test needs to wait for the task to finish before examining the resulting files.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp 5fe9cce97ee83d6a9e272879ec0395b5ace4a491
>
> Diff: https://reviews.apache.org/r/42842/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>