You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/27 09:57:10 UTC
[GitHub] [spark] juliuszsompolski commented on issue #25228:
[SPARK-28472][SQL][TEST][test-hadoop3.2] Add test for thriftserver protocol
versions
juliuszsompolski commented on issue #25228: [SPARK-28472][SQL][TEST][test-hadoop3.2] Add test for thriftserver protocol versions
URL: https://github.com/apache/spark/pull/25228#issuecomment-515671943
Sorry, more comments post LGTM:
Regarding testing V3 to V10 vs V1 to V10:
Simba drivers seem to connect initially with V1, make some initial calls (set -v to get all configs, GetInfo calls to get CLI_SERVER_NAME, CLI_DBMS_VER), and then it disconnects and reconnects with a higher version (V8 for thriftserver v1.2.1).
Maybe we could test starting to V1 then, and add some tests for other requests than executing queries (GetInfo calls, some metadata requests...)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org