[GitHub] [incubator-pinot] noahprince22 commented on a change in pull request #6250: Add server configuration to lazy load files from deep storage.

[GitBox <gi...@apache.org>]

noahprince22 commented on a change in pull request #6250:
URL: https://github.com/apache/incubator-pinot/pull/6250#discussion_r520148007



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/DataTypeTransformer.java
##########
@@ -109,7 +115,11 @@ public GenericRow transform(GenericRow record) {
         }
       }
       if (source != dest) {
-        value = dest.convert(value, source);
+        try {
+          value = dest.convert(value, source);
+        } catch (Exception e) {
+          throw new DataTypeConversionException(column, source, dest, e);

Review comment:
       Not really part of this PR, but figured I'd include it. This module throws errors that are pretty impossible to debug since they have no context on which column caused the explosion to happen. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org