You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2014/04/14 09:39:57 UTC
svn commit: r1587153 - in /myfaces/tobago/trunk:
tobago-example/tobago-example-test/src/main/webapp/test/sheet/
tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/
Author: lofwyr
Date: Mon Apr 14 07:39:57 2014
New Revision: 1587153
URL: http://svn.apache.org/r1587153
Log:
using omit attribute instead of onclick=comment
Modified:
myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/test/sheet/sheet-large.xhtml
myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java
Modified: myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/test/sheet/sheet-large.xhtml
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/test/sheet/sheet-large.xhtml?rev=1587153&r1=1587152&r2=1587153&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/test/sheet/sheet-large.xhtml (original)
+++ myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/test/sheet/sheet-large.xhtml Mon Apr 14 07:39:57 2014
@@ -49,11 +49,11 @@
<tc:gridLayout columns="2*;*"/>
</f:facet>
<tx:in readonly="true" label="Select 1st row"/>
- <tc:button label="Run" onclick="/* fixme: avoid submit */">
+ <tc:button label="Run" omit="true">
<tc:dataAttribute name="clickrow" value="0"/>
</tc:button>
<tx:in readonly="true" label="Select 2nd row"/>
- <tc:button label="Run" onclick="/* fixme: avoid submit */">
+ <tc:button label="Run" omit="true">
<tc:dataAttribute name="clickrow" value="1"/>
</tc:button>
</tc:box>
Modified: myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java?rev=1587153&r1=1587152&r2=1587153&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java (original)
+++ myfaces/tobago/trunk/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/html/standard/standard/tag/SheetRenderer.java Mon Apr 14 07:39:57 2014
@@ -978,7 +978,7 @@ public class SheetRenderer extends Layou
facesContext, UIMenuCommand.COMPONENT_TYPE, RendererTypes.MENU_COMMAND, id);
menuItem.setLabel(ResourceManagerUtils.getPropertyNotNull(facesContext, "tobago", label));
menuItem.setMarkup(markup);
- menuItem.setOnclick("/**/"); // XXX avoid submit
+ menuItem.setOmit(true);
ComponentUtils.putDataAttributeWithPrefix(menuItem, DataAttributes.SHEET_ID, sheetId);
menu.getChildren().add(menuItem);
}