[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2727: ARTEMIS-2394 Improve scheduling sync for AMQPConnectionContext

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2727: ARTEMIS-2394 Improve scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r303673922
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
 ##########
 @@ -87,9 +89,8 @@
 
    private final boolean useCoreSubscriptionNaming;
 
-   private boolean isSchedulingCancelled;
-   private ScheduledFuture scheduledFuture;
-   private final Object schedulingLock = new Object();
+   private static final FutureTask<Void> voidFuture = new FutureTask<>(() -> { }, null);
 
 Review comment:
   no i was literally meaning why the need for this, just set reference to null, i dont see the need for three states, two states is all thats needed looking at code, and the state changes.
   
   my first comment was just it should be capitlised, still not changed, but that was before i looked at its use and now question its need at all.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services