You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2019/02/12 17:51:45 UTC
[Impala-ASF-CR] IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12163 )
Change subject: IMPALA-7087: Read Parquet decimal columns with lower precision/scale than table metadata
......................................................................
Patch Set 3:
(3 comments)
Just noticed the comments about the README, but I plan to take a deeper look soon.
http://gerrit.cloudera.org:8080/#/c/12163/3/testdata/data/README
File testdata/data/README:
http://gerrit.cloudera.org:8080/#/c/12163/3/testdata/data/README@183
PS3, Line 183: decimal_stored_as_int32.parquet:
: Parquet file generated by Spark 2.3.1 that contains decimals stored as int32.
: Impala needs to be able to read such values (IMPALA-5542)
:
: decimal_stored_as_int64.parquet:
: Parquet file generated by Spark 2.3.1 that contains decimals stored as int64.
: Impala needs to be able to read such values (IMPALA-5542)
Here.
http://gerrit.cloudera.org:8080/#/c/12163/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:
http://gerrit.cloudera.org:8080/#/c/12163/1/tests/query_test/test_scanners.py@842
PS1, Line 842: pressed_page_size_summaries:
> Thanks for taking care of the other files too!
The decimal_stored_as_* files were in the README already.
http://gerrit.cloudera.org:8080/#/c/12163/1/tests/query_test/test_scanners.py@848
PS1, Line 848: " limit 10")
> I do not see this file in the patch and it is not mentioned in the README.
This was already in the README.
--
To view, visit http://gerrit.cloudera.org:8080/12163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafc8efd12379a39756e3e70f022a81a636dadb61
Gerrit-Change-Number: 12163
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 17:51:45 +0000
Gerrit-HasComments: Yes