[jira] Commented: (WICKET-563) Let Application create error pages

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507679 ] 

Juergen Donnerstag commented on WICKET-563:
-------------------------------------------

Your patch might be to intrusive to all the existing application out there. But I understand where you are going. I'm sure you are aware that you can achieve already exactly that without any changes to wicket core. Simply subclass RequestCycle.onRuntimeException() and implement exactly what your patch does. I probably would define some IRequestCycleExceptionHandler which defines the 4 methods and let Application implement it.

Juergen

> Let Application create error pages
> ----------------------------------
>
>                 Key: WICKET-563
>                 URL: https://issues.apache.org/jira/browse/WICKET-563
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 1.3.0-beta1
>            Reporter: Bart Molenkamp
>             Fix For: 1.3.0-rc1
>
>         Attachments: AbstractRequestCycleProcessor.java.patch, Application.java.patch
>
>
> Improvement to simplify error page creation. Error pages are now created by the Application, by:
> - onAuthorizationException() - for authorization exceptions
> - onPageExpiredException() - for pages that are expired
> - onRuntimeException() - for any other runtime exception
> Whether or not to show the stacktrace in the page is now determined in Application.onRuntimeException() (based on the getUnexpectedExceptionDisplay setting).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.