You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 18:41:03 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #2955: Update to arrow `19.0.0`
alamb opened a new pull request, #2955:
URL: https://github.com/apache/arrow-datafusion/pull/2955
Draft until arrow 19.0.0 is released, see https://github.com/apache/arrow-rs/issues/2051 for details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2955: Update to arrow `19.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2955:
URL: https://github.com/apache/arrow-datafusion/pull/2955#discussion_r931329072
##########
datafusion/common/src/scalar.rs:
##########
@@ -917,6 +917,11 @@ impl ScalarValue {
ScalarValue::iter_to_decimal_array(scalars, precision, scale)?;
Arc::new(decimal_array)
}
+ DataType::Decimal256(_, _) => {
Review Comment:
https://github.com/apache/arrow-rs/pull/2094 🎉
##########
datafusion/common/src/scalar.rs:
##########
@@ -527,15 +527,15 @@ macro_rules! build_values_list {
for scalar_value in $VALUES {
match scalar_value {
ScalarValue::$SCALAR_TY(Some(v)) => {
- builder.values().append_value(v.clone()).unwrap()
+ builder.values().append_value(v.clone());
Review Comment:
Many of the changes in this PR are driven by https://github.com/apache/arrow-rs/pull/2103 (that made the builders to infallible)
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -271,12 +271,18 @@ mod tests {
#[test]
fn test_cast_decimal_to_decimal() -> Result<()> {
- let array = vec![1234, 2222, 3, 4000, 5000];
+ let array = vec![
Review Comment:
This was a bug in the test -- the input data had 5 rows but the expected value had 6 values (and apparently `is_valid()` used to return `false` for an index off the end of the array and in arrow 19 it returns `true`)
##########
datafusion/common/src/scalar.rs:
##########
@@ -1112,14 +1117,14 @@ impl ScalarValue {
scalars: impl IntoIterator<Item = ScalarValue>,
precision: &usize,
scale: &usize,
- ) -> Result<DecimalArray> {
+ ) -> Result<Decimal128Array> {
Review Comment:
`DecimalArray` now is `DecimalArray128` to add support of `DecimalArray256` -- in https://github.com/apache/arrow-rs/issues/2101
##########
datafusion/core/src/avro_to_arrow/arrow_array_reader.rs:
##########
@@ -130,58 +130,52 @@ impl<'a, R: Read> AvroArrowArrayReader<'a, R> {
arrays.and_then(|arr| RecordBatch::try_new(projected_schema, arr).map(Some))
}
- fn build_boolean_array(
- &self,
- rows: RecordSlice,
- col_name: &str,
- ) -> ArrowResult<ArrayRef> {
+ fn build_boolean_array(&self, rows: RecordSlice, col_name: &str) -> ArrayRef {
Review Comment:
This is another example showing the builders have become infallable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2955: Update to arrow `19.0.0`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2955:
URL: https://github.com/apache/arrow-datafusion/pull/2955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2955: Update to arrow `19.0.0`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2955:
URL: https://github.com/apache/arrow-datafusion/pull/2955#issuecomment-1197245604
Benchmark runs are scheduled for baseline = c345f6d707a9bf8ed3395af997e8b3495ed6de7d and contender = cd3164918b0415b072a3109f3ccf654da7518ec1. cd3164918b0415b072a3109f3ccf654da7518ec1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7bafabbc22204aefb8d869140fdff621...8050f13ce0644997b253cca987daca5c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e8e6331c8b854777a94b728815c23bb4...f18d035b493840b7a46d72d56e785dde/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7e5949967ff44dfc813cc8c24663551e...8debcbf7162c48b4a6c7403054eddb71/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2bf26c8342224065a5e634c0ed8b8d9b...4577cbd6218c4e7b9d37e7abb533b24b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2955: Update to arrow `19.0.0`
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2955:
URL: https://github.com/apache/arrow-datafusion/pull/2955#discussion_r931334620
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -271,12 +271,18 @@ mod tests {
#[test]
fn test_cast_decimal_to_decimal() -> Result<()> {
- let array = vec![1234, 2222, 3, 4000, 5000];
+ let array = vec![
Review Comment:
cc @liu
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -271,12 +271,18 @@ mod tests {
#[test]
fn test_cast_decimal_to_decimal() -> Result<()> {
- let array = vec![1234, 2222, 3, 4000, 5000];
+ let array = vec![
Review Comment:
cc @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org