[GitHub] [hbase-operator-tools] petersomogyi commented on a change in pull request #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil…

[GitBox <gi...@apache.org>]

petersomogyi commented on a change in pull request #30: HBASE-23002 [HBCK2/hbase-operator-tools] Create an assembly that buil…
URL: https://github.com/apache/hbase-operator-tools/pull/30#discussion_r324176270
 
 

 ##########
 File path: hbase-operator-tools-assembly/src/main/assembly/bin.xml
 ##########
 @@ -0,0 +1,97 @@
+<?xml version="1.0"?>
+<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
+  <!--
+    /**
+     * Licensed to the Apache Software Foundation (ASF) under one
+     * or more contributor license agreements.  See the NOTICE file
+     * distributed with this work for additional information
+     * regarding copyright ownership.  The ASF licenses this file
+     * to you under the Apache License, Version 2.0 (the
+     * "License"); you may not use this file except in compliance
+     * with the License.  You may obtain a copy of the License at
+     *
+     *     http://www.apache.org/licenses/LICENSE-2.0
+     *
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     */
+    -->
+  <id>bin</id>
+  <formats>
+    <format>tar.gz</format>
+  </formats>
+  <includeBaseDirectory>true</includeBaseDirectory>
+  <moduleSets>
+    <moduleSet>
+
+      <!-- Enable access to all projects in the current multimodule build! -->
+      <useAllReactorProjects>true</useAllReactorProjects>
+      <!-- Now, select which projects to include in this module-set. -->
+      <includes>
+        <include>org.apache.hbase.operator.tools:hbase-hbck2</include>
+      </includes>
+      <sources>
+        <fileSets>
+          <fileSet>
+            <excludes>
+              <exclude>src/**</exclude>
+            </excludes>
+            <includes>
+              <include>README.md</include>
+            </includes>
+          </fileSet>
+        </fileSets>
+      </sources>
+      <binaries>
+        <outputDirectory>hbase-hbck2/</outputDirectory>
+        <unpack>false</unpack>
+        <dependencySets>
+          <dependencySet>
+            <excludes>
+              <exclude>org.slf4j:slf4j-api</exclude>
+            </excludes>
+          </dependencySet>
+        </dependencySets>
+      </binaries>
+    </moduleSet>
+  </moduleSets>
+  <!-- Include the generated LICENSE and NOTICE files -->
+  <files>
+    <file>
+      <source>${project.parent.basedir}/LICENSE.txt</source>
+      <outputDirectory>.</outputDirectory>
+      <destName>LICENSE.txt</destName>
+      <lineEnding>unix</lineEnding>
+    </file>
+    <file>
+      <source>${project.parent.basedir}/NOTICE.txt</source>
+      <outputDirectory>.</outputDirectory>
+      <destName>NOTICE.txt</destName>
+      <lineEnding>unix</lineEnding>
+    </file>
+    <file>
+      <source>${project.parent.basedir}/RELEASENOTES.md</source>
+      <outputDirectory>.</outputDirectory>
+      <destName>RELEASENOTES.md</destName>
+      <lineEnding>unix</lineEnding>
+    </file>
+    <file>
+      <source>${project.parent.basedir}/CHANGES.md</source>
+      <outputDirectory>.</outputDirectory>
+      <destName>CHANGES.md</destName>
+      <lineEnding>unix</lineEnding>
+    </file>
+    <file>
+      <source>${project.parent.basedir}/README.md</source>
+      <outputDirectory>.</outputDirectory>
+      <destName>README.md</destName>
 
 Review comment:
   README.md is also included in `moduleSets`. Are both of these lines are required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services